Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #12452 - incognito_used_timestamp is not recorded correctly #12990

Closed
GeetaSarvadnya opened this issue Dec 2, 2020 · 1 comment

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 2, 2020

Description

Follow up of #12452 - incognito_used_timestamp is not recorded correctly

Steps to Reproduce

  1. Clean profile 1.18.68
  2. Open a PT from normal window (using sidebar/hamburger menu)
  3. Open brave://local-state file in the normal tab window
  4. Note down the incognito_used_timestamp value
  5. Close the PT
  6. Open a TOR window tab from the normal window (using sidebar/hamburger menu)
  7. Refresh the local-state file which is opened in step 3
  8. Note down the incognito_used_timestamp value
  9. Values from step 4 and step 8 are different

Actual result:

incognito_used_timestamp value is different when TOR window is opened

Expected result:

As per the description #12452 (comment), opening a TOR window shouldn't change the incognito_used_timestamp value

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.18.68 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Windows 10 OS Version 2004 (Build 19041.630)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @iefremov @rebron

@GeetaSarvadnya
Copy link
Author

Discussed with @iefremov over the call - Refresh Brave://local-state file after step 5 fixes the issue. Hence closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant