-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically update settings page to add local node option when a local node is installed #13171
Comments
I'd argue "Local (embedded go-ipfs)" should ALWAYS be on the list, and when user selects it, Brave should always make a check if go-ipfs is installed, if not, install it and start it. Alternative is to have a separate "Install and run IPFS node" button above the "Method to resolve IPFS resources" that is hidden after install. Without either of those, we have onboarding problem, because we assume user will enter |
Completely agree. |
That sounds good as an alternate way to install rather than when they visit an ipfs:// URL. |
Verified
Steps:
|
This issue was broken out from @jessicaschilling's issue posted here: #13125
If you load brave://settings/extensions in a tab and then install the the IPFS local node in another tab. If you don't reload the settings page, then it shows a customized drop down list option.
Instead we should dynamically add a Local option and not wait for the page to be reloaded to show the proper value.We'll instead always have a Local node option. When a user selects Local node, if it is not installed, we'll open a tab with this URI:
ipfs://bafkreigxbf77se2an2u6hmg2kxxbhmenetc7dzvkd3rl4m2orlobjvqcqq
The text was updated successfully, but these errors were encountered: