Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't show SE onboarding with url #13392

Closed
deeppandya opened this issue Jan 6, 2021 · 1 comment · Fixed by brave/brave-core#7529
Closed

Shouldn't show SE onboarding with url #13392

deeppandya opened this issue Jan 6, 2021 · 1 comment · Fixed by brave/brave-core#7529

Comments

@deeppandya
Copy link

Description

SE onboarding should not show up when we have url in the search bar. it should show up only on the empty NTP.

Steps to reproduce

  1. From settings, click on Brave Rewards
  2. brave://rewards page would show up
  3. and click on search bar

Actual result

https://slack-files.com/T04PX1BU8-F01JTRUKD16-fd07c6783a

Expected result

Shouldn't show SE onboarding with url

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? yes
  • Can you reproduce this issue with the current Play Store Beta version? yes
  • Can you reproduce this issue with the current Play Store Nightly version? yes

Device details

  • Install type (ARM, x86): both
  • Device type (Phone, Tablet, Phablet): all devices
  • Android version: android 10

Brave version

1.20 nightly

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@deeppandya deeppandya added QA/Yes OS/Android Fixes related to Android browser functionality labels Jan 6, 2021
@deeppandya deeppandya self-assigned this Jan 6, 2021
@deeppandya deeppandya added this to the 1.20.x - Nightly milestone Jan 8, 2021
@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.20.85 x64 beta build

  • Verified SE onboarding is not shown when the URL bar is pre-populated
  • Verified SE onboarding is shown only when user taps on URL bar
Tab.SE.Onboarding.1.mp4

Verification passed on OnePlus 6T with Android 10 running 1.20.85 x64 beta build

  • Verified SE onboarding is not shown when the URL bar is pre-populated
  • Verified SE onboarding is shown only when user taps on URL bar
ARM-SE.Onboarding.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants