Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NTP background images for 2020/2021 #13447

Closed
deeppandya opened this issue Jan 8, 2021 · 3 comments · Fixed by brave/brave-core#7552
Closed

Update NTP background images for 2020/2021 #13447

deeppandya opened this issue Jan 8, 2021 · 3 comments · Fixed by brave/brave-core#7552
Assignees
@deeppandya
Labels
design A design change, especially one which needs input from the design team OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.20.x - Release

Comments

@deeppandya
Copy link

deeppandya commented Jan 8, 2021 •
edited by w0ts0n
Loading

Description

Update NTP background images for 2020/2021

Designs

Screen Shot 2020-11-11 at 6 21 09 PM

Assets

[redacted]

photo creds + links
2020-10 photo attribution and license.pdf

Test plan

Images should match those shown in our GDrive
@deeppandya deeppandya added design A design change, especially one which needs input from the design team QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Jan 8, 2021
@deeppandya deeppandya self-assigned this Jan 8, 2021
@deeppandya deeppandya mentioned this issue Jan 8, 2021
Merged
23 tasks
@deeppandya
Copy link
Author

@anthonypkeane @bsclifton where should we land this ? it's merged to 1.20 for now.

@deeppandya deeppandya added this to the 1.20.x - Nightly milestone Jan 11, 2021
@anthonypkeane
Copy link

Lets discuss with @kjozwiak tomorrow on the triage.

@srirambv
Copy link
Contributor

srirambv commented Jan 22, 2021 •
edited
Loading

Verification passed on OnePlus 6T with Android 10 running 1.20.85 x64 Beta build

  • Verified new NTP images are loaded on each new tab

  • Verified image credit link opens when tapped on photo credit

  • Logged Image credit missing for Corwin Prescott #13717 for missing credit for Corwin Prescott

    Screenshots
    Spence Moore (Ocean) Spencer Moore (Lake) Spencer Moore (Fern) Spencer Moore (Desert) Andrea Benz
    image image image image image
    Corvin Prescott (Olympic) Corvin Prescott (Crestone) Corvin Prescott (Canyon) Corvin Prescott (Beach) Su San Lee
    image image image image image
    Dylan Malval (Sea) Dylan Malval (Alps) Sora Sango Alex Plesovskich Zane Lee
    image image image image image

Verification passed on Samsung Tab A with Android 10 running 1.20.85 x64 Beta build

  • Verified new NTP images are loaded on each new tab

  • Verified image credit link opens when tapped on photo credit

  • Encountered Image credit missing for Corwin Prescott #13717

    Screenshots
    Spence Moore (Ocean) Spencer Moore (Lake) Spencer Moore (Fern) Spencer Moore (Desert) Andrea Benz
    image image image image image
    Corvin Prescott (Olympic) Corvin Prescott (Crestone) Corvin Prescott (Canyon) Corvin Prescott (Beach) Su San Lee
    image image image image image
    Dylan Malval (Sea) Dylan Malval (Alps) Sora Sango Alex Plesovskich Zane Lee
    image image image image image

@kjozwiak kjozwiak mentioned this issue Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
design A design change, especially one which needs input from the design team OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging a pull request may close this issue.

Add new images on NTP brave/brave-core
3 participants
@deeppandya @anthonypkeane @srirambv