Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPFS resolve type of disabled should disable #13472

Closed
bbondy opened this issue Jan 11, 2021 · 1 comment
Closed

IPFS resolve type of disabled should disable #13472

bbondy opened this issue Jan 11, 2021 · 1 comment
Assignees
@yrliou
Labels
feature/web3/ipfs OS/Desktop
Milestone
Closed / Dupe / I...

Comments

@bbondy
Copy link
Member

bbondy commented Jan 11, 2021

Description

Steps to Reproduce

  1. Navigate to brave://settings/?search=ipfs
  2. Set the Method to resolve IPFS resources to Disabled

Actual result:

It loads ipfs:// scheme resources through the gateway

Expected result:

It should not load ipfs:// scheme resources

Reproduces how often:

Always

Desktop Brave version:

All where IPFS is available (1.19.x and up)

Version/Channel Information:

1.19.x and up
@bbondy bbondy mentioned this issue Jan 11, 2021
Closed
@yrliou
Copy link
Member

yrliou commented Jan 11, 2021

Close this one as this has been resolved by uplifting brave/brave-core#7307.
Original issue: #12978.

@yrliou yrliou closed this as completed Jan 11, 2021
@yrliou yrliou added this to the Closed / Dupe / Invalid milestone Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
feature/web3/ipfs OS/Desktop
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

No branches or pull requests
2 participants
@bbondy @yrliou