Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background images of the new tab should be cached or optimized #1361

Closed
bsclifton opened this issue Oct 1, 2018 · 4 comments
Closed

Background images of the new tab should be cached or optimized #1361

bsclifton opened this issue Oct 1, 2018 · 4 comments

Comments

@bsclifton
Copy link
Member

Carried over from brave/browser-laptop#6503

The caching aspect is likely already fixed (meaning users should properly cache the images once they're loaded once, something that was broke in browser-laptop)- but we can also consider packaging these with the browser (so that no outbound connection is made)

Updated plan, per @petemill

  • have hard-coded property in wallpaper JSON that specifies if image is bundled.
  • In browser process, start a download process when all intensive tasks have completed (perhaps when initial windows have loaded) that downloads the other images. (or if we want to be more polite, perhaps only download 1 new image every time a new tab page is opened...?)
  • store in state which images have been downloaded, verify that they are on disk (or just find which images have been downloaded by looking in 'wallpaper' dir, and don't save to session-store).
  • new tab page reads from wallpaper json but only selects a random item from filtered list where item === bundled or item === downloaded
@bsclifton bsclifton added this to the 1.x Backlog milestone Oct 1, 2018
@bsclifton bsclifton changed the title Allow for Background images of the new tab should be cached or optimized Oct 1, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 5, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 5, 2018

Everything is changed to be local.

@rebron rebron closed this as completed Oct 5, 2018
@rebron rebron modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Oct 5, 2018
@kelna
Copy link

kelna commented Oct 22, 2018

So wallpapers could be a little bit of bigger resolution and less compression maybe? :)

@kjozwiak kjozwiak added closed/invalid and removed feature/new-tab perf priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 22, 2018
@TKList
Copy link

TKList commented Jan 30, 2019

How about a way to turn off the image altogether?

@merqrial
Copy link

@TKList There is an option on the bottom right in the latest version.

@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants