Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Crash on trying to update home button state #13680

Closed
samartnik opened this issue Jan 20, 2021 · 0 comments · Fixed by brave/brave-core#7668
Closed

[Android] Crash on trying to update home button state #13680

samartnik opened this issue Jan 20, 2021 · 0 comments · Fixed by brave/brave-core#7668
Assignees
Labels
OS/Android Fixes related to Android browser functionality QA/No release-notes/include

Comments

@samartnik
Copy link
Contributor

Description

Crash from GPS:

java.lang.NullPointerException: 
  at org.chromium.chrome.browser.toolbar.bottom.BraveBottomControlsCoordinator.updateHomeButtonState (BraveBottomControlsCoordinator.java:126)
  at org.chromium.chrome.browser.toolbar.BraveToolbarManager.lambda$new$0$BraveToolbarManager (BraveToolbarManager.java:140)
  at org.chromium.chrome.browser.toolbar.BraveToolbarManager$$Lambda$0.onHomepageStateUpdated (BraveToolbarManager.java:4)
  at org.chromium.chrome.browser.homepage.HomepageManager.notifyHomepageUpdated (HomepageManager.java:101)
  at org.chromium.chrome.browser.homepage.HomepageManager.setPrefHomepageEnabled (HomepageManager.java:207)
  at org.chromium.chrome.browser.homepage.settings.HomepageSettings.onSwitchPreferenceChange (HomepageSettings.java:149)
  at org.chromium.chrome.browser.homepage.settings.HomepageSettings.lambda$onCreatePreferences$0$HomepageSettings (HomepageSettings.java:83)
  at org.chromium.chrome.browser.homepage.settings.HomepageSettings$$Lambda$0.onPreferenceChange (HomepageSettings.java:2)
  at androidx.preference.Preference.callChangeListener (Preference.java:1118)
  at androidx.preference.TwoStatePreference.onClick (TwoStatePreference.java:67)
  at org.chromium.components.browser_ui.settings.ChromeSwitchPreference.onClick (ChromeSwitchPreference.java:55)
  at androidx.preference.Preference.performClick (Preference.java:1182)
  at androidx.preference.Preference.performClick (Preference.java:1166)
  at androidx.preference.SwitchPreferenceCompat.performClick (SwitchPreferenceCompat.java:193)
  at androidx.preference.SwitchPreferenceCompat.performClick (SwitchPreferenceCompat.java:1)
  at androidx.preference.Preference$1.onClick (Preference.java:181)
  at android.view.View.performClick (View.java:7448)
  at android.view.View.performClickInternal (View.java:7425)
  at android.view.View.access$3600 (View.java:810)
  at android.view.View$PerformClick.run (View.java:28305)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:223)
  at android.app.ActivityThread.main (ActivityThread.java:7660)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:592)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:947)

Steps to reproduce

I wasn't able to reproduce it. Most likely happens on trying to click home button before native is initialized. Probably on low end devices.

Actual result

Crash

Expected result

No crash

Issue reproduces how often

Not reproducible on my devices.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.19.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants