Adblock rules should apply to HTTP subresources of an IPFS page

[bbondy]

Description

Applying adblock rules to IPFS doesn't work well because CIDs will often have path based fragments that are used in ABP filter syntax. However it should apply to HTTP(S) subresources of an IPFS page.

This issue should be fixed after: #10220

Steps to Reproduce

1. Navigate to an IPFS page and open up the JS console
2. Type in this script:

var script = document.createElement('script')
script.src = 'https://brianbondy.com/static/js/analytics.js'
document.body.appendChild(script)

3. The resource should be blocked.

Actual result:

The resource is not blocked.

Expected result:

The resource should be blocked and the block count should increase by 1.

Reproduces how often:

Always

Brave version (brave://version info)

1.21.x and below (all before this is fixed)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

[stephendonner]

Verified FIXED using

Brave	1.21.51 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 11.2.1 (Build 20D74)

Before the fix, with the inline testcase, on

Brave	1.20.103 Chromium: 88.0.4324.152 (Official Build) (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}

the script resource isn't blocked. It is using 1.21.51, with the following message:

GET https://brianbondy.com/static/js/analytics.js net::ERR_BLOCKED_BY_CLIENT

---

Verification passed on

Brave	1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Ubuntu 18.04 LTS

Verified test plan from the description
Verified the script is blocked when Shields are enabled

Verified the number of Trackers and ads blocked is increased

Logged #14147 when shields are disabled, the resources are blocked anyway.

---

Verification passed on

Brave | 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
-- | --
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | Windows 10 OS Version 2004 (Build 19041.804)

• Encountered HTTP subresources on ipfs are blocked even when Shields are disabled #14147