Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] browser notifications (web push) are automatically removed from notification center. #13771

Closed
hoony9x opened this issue Jan 26, 2021 · 8 comments

Comments

@hoony9x
Copy link

hoony9x commented Jan 26, 2021

Description

To reproduce problem and take screen shots quickly, I used below site.

Several sites support browser notification. (eg. Facebook, Instagram, Youtube)

When these sites send notification, they are displayed like this.
Screen Shot 2021-01-26 at 21 33 54

After few seconds, they are moved to notification center like this.
Screen Shot 2021-01-26 at 21 34 11

Some notification requires "Interaction".
Screen Shot 2021-01-26 at 21 40 34

This type of notifications are permanantly remain on the screen until I manually select close button of it.

In macOS "System Preferences - Notifications", Google Chrome has 2 types of notification settings.
Screen Shot 2021-01-26 at 21 42 17

Notification that does not require Interaction uses "Banners" setting, and the other one (requiresInteraction) uses "Alerts" setting.

HOWEVER, when I install Brave Browser, it has only "Alerts" notification setting.
Screen Shot 2021-01-26 at 21 45 15

When I receive notification using Brave Browser, It appears on the screen like this.
Screen Shot 2021-01-26 at 21 46 07

Few seconds later, it is removed from screen.
Howeber, unlinke Google chrome, I can't find it in the notification center.
Screen Shot 2021-01-26 at 21 51 26

For "Interaction Required" notification, it permanantly remains on the screen like Google Chrome does.
Screen Shot 2021-01-26 at 21 55 41

Can you fix this problem?

  • Like, Using other browser(eg. Google Chrome)'s method that uses two different notification settings.

Steps to Reproduce

In general case,

  1. Allow notification from site which supports it.
  2. Get any notification from site.

To reproduce problem and take screen shots quickly, I used below site.

For above site,

  1. Turn on notification.
  2. Click any button to receive notifcation.

If you click button in the "Require Interaction" section, you will receive "Interaction required notifcation" as a mentioned above.

Actual result:

  • Notifcation that does not require interaction does not exists on the "notification center".

Expected result:

  • Notifcation that does not require interaction should remain on the "notifcation center".

Reproduces how often:

Always.

Brave version (brave://version info)

  • 1.19.86 (Stable Channel)
  • 1.20.85 (Beta Channel)
  • 1.20.90 (Dev Channel)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    • In this issue report, I took screen shots using "Dev" channel.
    • But, I tested on "Stable", "Beta", "Dev" channel and they reproduce same results.
  • Can you reproduce this issue with the beta channel?
    • Yes.
  • Can you reproduce this issue with the nightly channel?
    • It was not tested on "Nightly" channel.

Other Additional Information:

  • Is the issue reproducible on the latest version of Chrome?
    • No.

Miscellaneous Information:

@rebron
Copy link
Collaborator

rebron commented Feb 9, 2021

cc: @tmancey Can you take a look when you get a chance?

@rebron rebron added needs-more-info The report requires more detail before we can decide what to do with this issue. OS/macOS and removed QA Pass-macOS labels Feb 9, 2021
@tmancey
Copy link
Contributor

tmancey commented Feb 10, 2021

@rebron Sure.

@LampPrinter
Copy link

Has this issue been fixed? I am still experiencing it.

@tmancey
Copy link
Contributor

tmancey commented Aug 12, 2021

@LampPrinter this has not been resolved. This is on my list to investigate after some other issues. Thank you, Terry

@tmancey
Copy link
Contributor

tmancey commented Oct 11, 2021

@hoony9x @LampPrinter can you please let us know if this issue is still occurring on the latest release as we made some changes which should have resolved the issue. Thank you, Terry

@tmancey tmancey self-assigned this Oct 11, 2021
@LampPrinter
Copy link

@hoony9x @LampPrinter can you please let us know if this issue is still occurring on the latest release as we made some changes which should have resolved the issue. Thank you, Terry

Notifications are working fine for me in the latest beta.

@hoony9x
Copy link
Author

hoony9x commented Oct 12, 2021

@hoony9x @LampPrinter can you please let us know if this issue is still occurring on the latest release as we made some changes which should have resolved the issue. Thank you, Terry

It finally works fine for me with stable release 1.30.87 (Chromium 94.0.4606.71). Thanks a lot!

@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Oct 18, 2021
@tmancey tmancey added this to the 1.32.x - Beta milestone Oct 18, 2021
@tmancey tmancey closed this as completed Oct 18, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.32.74 Chromium: 95.0.4638.54 (Official Build) dev (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave
  3. clicked on the toggle to Enable Notifications on https://web-push-book.gauntface.com/demos/notification-examples/
  4. clicked on various options under Examples
  5. waited for them to time out
  6. clicked on the system clock in the upper-right corner, to open notifications
  7. confirmed I saw the ones I fired off but never acknowledged/dismissed, show up here
example example example example
Screen Shot 2021-10-19 at 4 29 59 PM Screen Shot 2021-10-19 at 4 35 55 PM Screen Shot 2021-10-19 at 4 39 04 PM Screen Shot 2021-10-19 at 4 42 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants