Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused cookie exceptions in brave-core/cookie_settings_base.cc #14032

Closed
ryanbr opened this issue Feb 8, 2021 · 1 comment · Fixed by brave/brave-core#7861
Closed

Comments

@ryanbr
Copy link

ryanbr commented Feb 8, 2021

Description

Since landing ephemeral storage, was asked to review to changes in https://github.com/brave/brave-core/blob/master/chromium_src/components/content_settings/core/common/cookie_settings_base.cc

Fixes for brave/brave-core#5960 ref: #10494 (Fixes Twitch clips on Reddit)

  • Embedded Twitch videos played back fine in reddit.com

and brave/brave-core#6553 ref: #11532 (Fix login issue on bitbucket.org)

  • Was able to login to bit bucket, without it failing.

The rest of the fixes in https://github.com/brave/brave-core/blob/master/chromium_src/components/content_settings/core/common/cookie_settings_base.cc are still needed

Tested in a ci brave build with all cookie exceptions removed.

@ryanbr
Copy link
Author

ryanbr commented Feb 8, 2021

Retested to be sure on the updated build.

https://www.reddit.com/r/LivestreamFail/comments/lf2y48/cyberpunk_strikes_again_gta_rp/ (Stream plays back with no error)

and https://www.bitbucket.org worked without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant