We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since landing ephemeral storage, was asked to review to changes in https://github.com/brave/brave-core/blob/master/chromium_src/components/content_settings/core/common/cookie_settings_base.cc
Fixes for brave/brave-core#5960 ref: #10494 (Fixes Twitch clips on Reddit)
reddit.com
and brave/brave-core#6553 ref: #11532 (Fix login issue on bitbucket.org)
The rest of the fixes in https://github.com/brave/brave-core/blob/master/chromium_src/components/content_settings/core/common/cookie_settings_base.cc are still needed
Tested in a ci brave build with all cookie exceptions removed.
The text was updated successfully, but these errors were encountered:
Retested to be sure on the updated build.
https://www.reddit.com/r/LivestreamFail/comments/lf2y48/cyberpunk_strikes_again_gta_rp/ (Stream plays back with no error)
https://www.reddit.com/r/LivestreamFail/comments/lf2y48/cyberpunk_strikes_again_gta_rp/
and https://www.bitbucket.org worked without issue.
https://www.bitbucket.org
Sorry, something went wrong.
ryanbr
Successfully merging a pull request may close this issue.
Description
Since landing ephemeral storage, was asked to review to changes in https://github.com/brave/brave-core/blob/master/chromium_src/components/content_settings/core/common/cookie_settings_base.cc
Fixes for brave/brave-core#5960 ref: #10494 (Fixes Twitch clips on Reddit)
reddit.com
and brave/brave-core#6553 ref: #11532 (Fix login issue on bitbucket.org)
The rest of the fixes in https://github.com/brave/brave-core/blob/master/chromium_src/components/content_settings/core/common/cookie_settings_base.cc are still needed
Tested in a ci brave build with all cookie exceptions removed.
The text was updated successfully, but these errors were encountered: