Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option to disable notification popup under site info #1406

Open
srirambv opened this issue Oct 3, 2018 · 4 comments
Open

Allow option to disable notification popup under site info #1406

srirambv opened this issue Oct 3, 2018 · 4 comments
Labels
feature/notifications priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 3, 2018

Description

Reported from community : https://community.brave.com/t/option-to-disable-notification-popups/33989

Most of the websites now asks me to enable notifications through a popup, it would be nice if there is an option to suppress this completely or better like how plugins this can be handled to show an icon, and user can tap on it to enable it.

Actual result:

image

Expected result:

Have a settings options to disable the notification.

Reproduces how often:

Brave version (chrome://version info)

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes
  • Does it reproduce on browser-laptop? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

@bbondy bbondy added this to the 1.x Backlog milestone Oct 3, 2018
@Brave-Matt
Copy link

I'm I misunderstanding the issue in some way?Steps to disable pop-up notifications are
Settings -->Privacy and Security --> Content Settings --> Notifications

@bsclifton
Copy link
Member

bsclifton commented Oct 4, 2018

Related: Allow me to block all notifications requesting permission #751

@srirambv
Copy link
Contributor Author

srirambv commented Oct 4, 2018

@Brave-Matt Disabling notifications from content settings doesn't block the popup shown under site info. Chromium removed the Stop all notifications settings long back. This is somewhat similar to #751 but the user only wants to disable the notification bubble but would still want the notification icon on the URL bar.

Honestly it's sometimes annoying that the bubble opens up when you just want to browse the site. I'd give a +1 for this feature to be added under settings to stop showing the bubble. The bubble in itself isn't useful as any change you need to do has to be done on the icons that show up in URL bar.

@Brave-Matt
Copy link

Brave-Matt commented Oct 4, 2018

@srirambv, thanks for elaborating.
I think its worth noting that this functionality does already exist, its just not easily accessible. For example, to disallow pop-up notifications of any kind:
Settings --> Privacy and Security --> Content Settings --> Notifications --> Toggle "off"
Then
Settings --> Privacy and Security --> Content Settings --> Location --> Toggle "off"
shownotis

shownotis2

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 5, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/notifications priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion
Projects
None yet
Development

No branches or pull requests

5 participants