Changing orientation doesn't show bottom toolbar

[srirambv]

Description

Changing orientation doesn't show bottom toolbar

Steps to reproduce

1. Launch browser in landscape mode
2. Visit a page in landscape mode
3. Rotate to portrait
4. Bottom toolbar is missing, menu and tab count shows up on top
5. Rotate to landscape and back to portrait, bottom toolbar shows up

Actual result

Bottom.toolbar.issue.mp4

Expected result

Should not hide bottom toolbar when orientation is changed

Issue reproduces how often

Easy

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? Yes
• Can you reproduce this issue with the current Play Store Beta version? Yes
• Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Phone
• Android version: 10

Brave version

1.20.103

Website problems only

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @samartnik

[samartnik]

Seems to be not reproducible on my devices. @srirambv did you do anything else prior to these steps?

[srirambv]

@samartnik no specific steps you can try the following which repro's 90% of the time

• Clean install any build (do not launch)
• Change device orientation to landscape
• Launch Brave in landscape orientation
• Visit a page
• Change orientation to portrait
• Bottom toolbar is missing
• Change to landscape and back to portrait shows bottom toolbar

Here's a recording on PlayStore version (Do not the onboarding modals force rotation so closing them and showing. It even happens with P3A onboarding is shown)

14211.mp4

[Revenrof]

@samartnik regarding bottom toolbar orientation, I got "bottom toolbar" thingy in landscape mode IF, I open "tabs switcher".

In NTP landscape mode the bottom toolbar shown in split second and then puff. Gone.

But, IF the tab is used to open any url (including "chrome://what-do-I-call-this-?") the bottom toolbar is shown.

• tab opening "https://brave.com" :
  

• tab opening "chrome://version" :
  

• tab opening "about:blank" :
  

However, none of them ( the buttons) is working. Is it supposed to be like this? Do I need to open new issue?

[samartnik]

@Revenrof it is not expected behavior as bottom toolbar shouldn't be visible in landscape mode. Yes, please open new issue as this one is different.
upd: actually I created issue myself, thank you for reporting!

[srirambv]

Unable to repro the issue on nightly/beta/release. Closing the issue for now as invalid. Will reopen if I can get it to reproduce