Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on buy button doesn't hide the widget when landing page is loaded #14405

Closed
srirambv opened this issue Mar 1, 2021 · 3 comments · Fixed by brave/brave-core#8527
Closed
Assignees
Labels
feature/widgets OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2021

Description

Clicking on buy button doesn't hide the widget when landing page is loaded

Steps to reproduce

  1. Connect to Binance widget
  2. Click on Buy button on .com/.us
  3. Landing page loads but the widget remains open

Actual result

BinanceWidgetAutoHide.mp4

Expected result

Widget should auto-hide once the user clicks on Buy button

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Probably

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Tablet
  • Android version: 10

Brave version

1.21.70

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @deeppandya

@srirambv srirambv added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality feature/widgets labels Mar 1, 2021
@deeppandya
Copy link

@srirambv this issue should be fixed. would you please verify it again ?

@srirambv
Copy link
Contributor Author

srirambv commented Apr 8, 2021

@deeppandya still doesn't seem to be fixed on 1.23.63 build

Binance.Buy.Button.mp4

@srirambv
Copy link
Contributor Author

srirambv commented May 6, 2021

Verification passed on Samsung Tab A with Android 10 running 1.25.51 x64 beta build

  • Verified selecting buy button auto hides the widget menu when landing page is loaded

Verification passed on OnePlus 6T with Android 10 running 1.25.51 x64 beta build

  • Verified selecting buy button auto hides the widget menu when landing page is loaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/widgets OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@deeppandya @srirambv and others