Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop node if switched from local node to another option #14450

Closed
spylogsster opened this issue Mar 3, 2021 · 1 comment · Fixed by brave/brave-core#8366
Closed

Stop node if switched from local node to another option #14450

spylogsster opened this issue Mar 3, 2021 · 1 comment · Fixed by brave/brave-core#8366

Comments

@spylogsster
Copy link

spylogsster commented Mar 3, 2021

Stop node if switched from local node to another option

Steps to Reproduce

  1. Select local node in settings
  2. Visit ipfs:// url
  3. Check the node is launched
  4. Select gateway in settings, close settings tab
  5. Check the node is stopped

Actual result:

Local node stays launched

Expected result:

Local node is stopped

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@spylogsster spylogsster self-assigned this Mar 3, 2021
@spylogsster spylogsster changed the title Stop node if switch from local node to gateway Stop node if switched from local node to gateway Mar 26, 2021
@spylogsster spylogsster changed the title Stop node if switched from local node to gateway Stop node if switched from local node to other option Mar 26, 2021
@spylogsster spylogsster changed the title Stop node if switched from local node to other option Stop node if switched from local node to anotheroption Mar 26, 2021
@spylogsster spylogsster changed the title Stop node if switched from local node to anotheroption Stop node if switched from local node to another option Mar 26, 2021
@spylogsster spylogsster added this to the 1.24.x - Nightly milestone Mar 29, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 30, 2021
@stephendonner
Copy link

stephendonner commented Mar 30, 2021

Verified PASSED using the inline testplan here on nightly build

Brave 1.24.35 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
Revision e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS macOS Version 11.2.3 (Build 20D91)

Steps:

  1. Opened brave://settings and selected Local node from Method to resolve IPFS resources
  2. Loaded brave://ipfs-internals
  3. Verified the node is launched
  4. Selected Gateway in brave://settings for Method to resolve IPFS resources
  5. Verified the node was stopped

ipfs-gateway-stop

Verification passed on

Brave 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified the above test plan

image


Verification passed on

Brave | 1.24.82 Chromium: 90.0.4430.93 (Official Build) (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verified the above test plan mentioned
image

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment