Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclear what element is in focus on the Tip banner #14595

Closed
LaurenWags opened this issue Mar 9, 2021 · 0 comments
Closed

unclear what element is in focus on the Tip banner #14595

LaurenWags opened this issue Mar 9, 2021 · 0 comments
Assignees
Labels
feature/rewards feature/user-interface All UI related OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

When you open the Tip banner it is not immediately clear which element is in focus. If you select the tab key you will see some element selected, but you have no idea where you started.

Related issue: #6986

Steps to Reproduce

  1. Clean profile
  2. Enable Rewards
  3. Navigate to a site
  4. Open panel, then tip banner

Actual result:

user has no idea what is in focus:
Screen Shot 2021-03-09 at 1 42 12 PM

when I select the tab key, some element is shown as focused (in this case, it is the twitter icon):
Screen Shot 2021-03-09 at 1 46 43 PM

Expected result:

Some element should be indicated as in focus when the banner is opened to help with accessibility

Reproduces how often:

100%

Brave version (brave://version info)


Brave | 1.21.74 Chromium: 89.0.4389.72 (Official Build) (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H524)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

previous issue was #6985, but it was closed as the tip banner design has changed since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards feature/user-interface All UI related OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants