Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DDG UA #15156

Closed
pes10k opened this issue Apr 6, 2021 · 8 comments · Fixed by brave/brave-core#9871
Closed

Remove DDG UA #15156

pes10k opened this issue Apr 6, 2021 · 8 comments · Fixed by brave/brave-core#9871
Assignees
@ShivanKaul
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include webcompat/lists Webcompat issues that seem to be because our lists of what to or not to block could be improved.
Milestone
1.31.x - Release

Comments

@pes10k
Copy link
Contributor

pes10k commented Apr 6, 2021

After talking with DDG, @lukemulks has confirmed that we no longer need to send DDG a custom, "includes Brave" UA.

This issue is to remove the DDG UA special case.
@pes10k pes10k added webcompat/lists Webcompat issues that seem to be because our lists of what to or not to block could be improved. OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 6, 2021
@lukemulks
Copy link

+1

bumping this up for visibility

@pes10k
Copy link
Contributor Author

pes10k commented Aug 23, 2021

Sounds good, will work with @ShivanKaul to get this sorted. Thanks @lukemulks !

@pes10k pes10k added privacy privacy-pod Feature work for the Privacy & Web Compatibility pod labels Aug 23, 2021
@ShivanKaul ShivanKaul mentioned this issue Aug 26, 2021
Merged
24 tasks
@ShivanKaul
Copy link
Collaborator

Just FYI, I've created a PR to remove the code that adds "Brave" to the UA string for Netflix and DDG that I'll be merging in soon.

Before:
image

After:
image

@ShivanKaul ShivanKaul added this to the 1.31.x - Nightly milestone Sep 1, 2021
@anthonypkeane
Copy link

Does iOS need to implement this also @pes10k ?

@pes10k
Copy link
Contributor Author

pes10k commented Sep 2, 2021

I dont know if iOS is currently sending it, but if it is, we should stop :)

@pes10k
Copy link
Contributor Author

pes10k commented Sep 2, 2021

I dont see anything like that in the iOS code base, but iOS team would know better

@stephendonner
Copy link

stephendonner commented Sep 9, 2021 •
edited by GeetaSarvadnya
Loading

Verified PASSED using

Brave 1.31.28 Chromium: 93.0.4577.63 (Official Build) nightly (x86_64)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS macOS Version 12.0 (Build 21A5506j)

Steps:

  1. clean profile
  2. launched Brave
  3. opened Developer Tools, Network tab
  4. loaded duckduckgo.com and netflix.com
  5. examined the HTTP request's user-agent string for both

Confirmed "Brave" as a string in UAs has been removed:

With fix (nightly):

duckduckgo.com netflix.com
Screen Shot 2021-09-08 at 6 47 17 PM Screen Shot 2021-09-08 at 6 47 03 PM

Without fix (beta):

duckduckgo.com netflix.com
Screen Shot 2021-09-08 at 6 44 56 PM Screen Shot 2021-09-08 at 6 45 29 PM

Verified PASSED using

Brave 1.31.64 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS Linux

Steps:

  1. clean profile
  2. launched Brave
  3. opened Developer Tools, Network tab
  4. loaded duckduckgo.com and netflix.com
  5. examined the HTTP request's user-agent string for both

Confirmed "Brave" as a string in UAs has been removed:

With fix (beta):

duckduckgo.com netflix.com
Screen Shot 2021-09-28 at 4 20 43 PM Screen Shot 2021-09-28 at 4 20 55 PM

Without fix (release):

duckduckgo.com netflix.com
Screen Shot 2021-09-28 at 4 21 45 PM Screen Shot 2021-09-28 at 4 22 10 PM

Verification passed on

Brave | 1.31.66 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
-- | --
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Reproduced the issue in 1.30.86

image

Confirmed Brave string is removed from user-agent in 1.31.x
image

@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2021

Verification passed on Samsung Tab A with Android 10 running 1.31.67 x64 beta build

  • Verified Brave UA is removed
DDG Netflix
image image

Verification passed on Oppo Reno 5 with Android 11 running 1.31.67 x64 beta build

  • Verified Brave UA is removed
DDG Netflix
image image

@kjozwiak kjozwiak mentioned this issue Oct 19, 2021
Closed
@kjozwiak kjozwiak mentioned this issue Nov 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShivanKaul ShivanKaul

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include webcompat/lists Webcompat issues that seem to be because our lists of what to or not to block could be improved.
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Remove special-cased Netflix and DDG Brave UA brave/brave-core
8 participants
@pes10k @stephendonner @ShivanKaul @anthonypkeane @lukemulks @srirambv @LaurenWags @GeetaSarvadnya