Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon is not shown #1521

Closed
NejcZdovc opened this issue Oct 11, 2018 · 1 comment · Fixed by brave/brave-core#888
Closed

Favicon is not shown #1521

NejcZdovc opened this issue Oct 11, 2018 · 1 comment · Fixed by brave/brave-core#888

Comments

@NejcZdovc
Copy link
Contributor

Description

When watching twitch videos, publisher icon is not shown until you reload rewards page

Steps to Reproduce

  1. clean profile
  2. enable rewards
  3. go to twitch in a new window and watch a video (VOD)
  4. rewards settings page has missing favicon

Actual result:

Publisher has missing favicon. When you reload settings page, favicon is displayed correctly

Expected result:

Favicon should be display correctly immediately

Reproduces how often:

Brave version (chrome://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Oct 11, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 19, 2018
@mandar-brave mandar-brave added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Jan 8, 2019
@jasonrsadler jasonrsadler self-assigned this Jan 19, 2019
@jasonrsadler jasonrsadler modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 22, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 7, 2019

Verification passed on

Brave 0.60.19 Chromium: 72.0.3626.81 (Official Build) beta (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Windows 10

Verified passed with

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants