Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"youtube.com on YouTube 'creator'" attribution shows up in auto-contribute list #15216

Closed
stephendonner opened this issue Apr 9, 2021 · 3 comments

Comments

@stephendonner
Copy link

Description

"youtube.com on YouTube 'creator'" shows up in auto-contribute list

Steps to Reproduce

  1. new profile, launch with --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=4
  2. enable Rewards
  3. accept the UGP BAT grant on staging
  4. load youtube.com
  5. search for Jonathan Sampson
    6.click on Jonathan Sampson
  6. click on Videos
  7. click on the Netscape, circa 1994. video and play it
  8. wait for Auto-Contribution to happen
  9. load brave://rewards-internals and/or brave://rewards and look at the AC entries

Actual result:

The unverified youtube.com on YouTube creator shows up in the Auto-Contribute list, alongside verified creators.

Screen Shot 2021-04-09 at 1 17 38 PM

Screen Shot 2021-04-09 at 1 24 27 PM

Expected result:

Not 100%; first time I've seen this appear like this?

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.23.69 Chromium: 90.0.4430.61 (Official Build) (x86_64)
Revision dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @LaurenWags @zenparsing @emerick

@stephendonner
Copy link
Author

stephendonner commented Apr 9, 2021

Forgot to mention: not a regression, as @LaurenWags reproduced it this on 1.22.x as well.

@kenherbert
Copy link

kenherbert commented May 4, 2021

I'm seeing a similar (assuming related) issue in beta 1.24.60/76.

Visiting a verified channel directly adds the unverified YouTube account to the AC list, but not the verified creator.
Screen Shot 2021-05-05 at 01 34 45

The verified creator is only added to the AC list after one of their videos is opened/played.

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 3, 2023

Closing as dupe of: #22859

@Miyayes Miyayes closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants