-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two new tab events are triggered when a new tab is opened #15285
Comments
Opened a new tab with id
is triggered twice when a new tab is opened
Not reproducible on Linux
|
Closing as working as expected as two different tabs were opened. One from rewards and another when you manually typed the url. Thanks |
@tmancey I have opened only one new tab. I have enabled rewards from BR panel but I haven't clicked on rewards settings to open the rewards tab. I have just clicked on |
@tmancey Please find the recorded file, I can reproduce the issue consistently in windows, after enabling rewards, I am not clicking on https://drive.google.com/file/d/1qTv7IHa3C4ShQcCN9OwsKU09Q1gRu-zx/view?usp=sharing |
@GeetaSarvadnya This is working as expected as on the video I only see the 2nd "Opened a new tab with id" appear when you open the About page. |
Description
Found while testing #14045
Opened a new tab with id
is triggered twice when a new tab is openedSteps to Reproduce
User Activity - Default values - Threshold - not reached
in https://github.com/brave/internal/issues/763+
iconOpened a new tab with id 7
andOpened a new tab with id 5
Actual result:
Two new tab events are triggered
Opened a new tab with id 7
andOpened a new tab with id 5
Expected result:
Only one new tab event should be triggered
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/legacy_qa @tmancey @moritzhaller @jsecretan
The text was updated successfully, but these errors were encountered: