Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting for tab groups #15394

Closed
anthonypkeane opened this issue Apr 20, 2021 · 2 comments · Fixed by brave/brave-core#8578
Closed

Add setting for tab groups #15394

anthonypkeane opened this issue Apr 20, 2021 · 2 comments · Fixed by brave/brave-core#8578
Assignees
@samartnik
Labels
feature/settings OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.23.x - Release #2

Comments

@anthonypkeane
Copy link

anthonypkeane commented Apr 20, 2021 •
edited
Loading

Description

Slack: https://bravesoftware.slack.com/archives/DCLU7012P/p1618935977006400

In Settings->Appearance please add a setting to enable/disable Tab Groups

Title
Enable Tab Groups

Default = On
@anthonypkeane anthonypkeane added priority/P2 A bad problem. We might uplift this to the next planned release. OS/Android Fixes related to Android browser functionality labels Apr 20, 2021
@samartnik samartnik self-assigned this Apr 20, 2021
@samartnik samartnik mentioned this issue Apr 20, 2021
Merged
24 tasks
@samartnik samartnik added this to the 1.25.x - Nightly milestone Apr 20, 2021
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.23.73 x64 build

  • Verified new setting for tab groups is available under Settings -> Appearance
  • Verified enable/disable setting triggers restart prompt
  • Verified disabling setting doesn't show tab groups or allow tabs to be grouped via context menu
  • Verified enabling setting allows grouping of tabs via context menu
Android.ARM.group.setting.mp4

Logged issue for setting available in Tablet #15450

@samartnik samartnik reopened this Apr 22, 2021
@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Apr 22, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Apr 22, 2021 •
edited
Loading

We'll QA the above and use #15453 as the release note issue for 1.23.x - Release #3.

@kjozwiak kjozwiak mentioned this issue Apr 23, 2021
Closed
@kjozwiak kjozwiak mentioned this issue Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
feature/settings OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.23.x - Release #2
Development

Successfully merging a pull request may close this issue.

[Android] Added option for Tab Groups brave/brave-core
4 participants
@kjozwiak @anthonypkeane @srirambv @samartnik