Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS configuration broken in french #15586

Closed
Welteam opened this issue May 1, 2021 · 2 comments · Fixed by brave/brave-core#9232
Closed

IPFS configuration broken in french #15586

Welteam opened this issue May 1, 2021 · 2 comments · Fixed by brave/brave-core#9232

Comments

@Welteam
Copy link

Welteam commented May 1, 2021

Description

I activated IPFS support and I was redirected to the page where I can choose between the local or public gateway option however none of the buttons worked. The page was like frozen (there was probably an error in the script that prevented it's execution). However when I restarted brave with english UI and opened the same page, everything worked so I believe the issue is with localization.

Steps to Reproduce

  1. Go to the language settings and add "French (france)" as your main and ui language
  2. Go to IPFS settings and turn on IPFS companion
  3. I believe the page in question is automatically opened in a new tab, I can't find it anymore. It had an image with both the IPFS and Brave logos, an orange "local node" button and a grey "public node" button.

Actual result:

None of the buttons did anything, even the "settings" link at the bottom of the page didn't work.

Expected result:

The buttons work, like they do when brave is configured for english.

Reproduces how often:

Every time. I reloaded the page in french multiple time but the javascript errors seemed inconsistent.

Brave version (brave://version info)

Brave | 1.23.75 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2009 (Build 19042.928)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? /
  • Can you reproduce this issue with the nightly channel? /

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? I believe IPFS support is a brave thing but I don't have Chrome

Miscellaneous Information:

@stephendonner
Copy link

I can reproduce this using

Brave 1.28.3 Chromium: 91.0.4472.106 (Build officiel) nightly (x86_64)
Révision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
Système d'exploitation macOS Version 11.4 (assemblage 20F71)

Pre-requisities:

Set OS language to French, and do so in Brave, too, at brave://settings/languages

Steps:

  1. new profile
  2. go to brave://settings/ipfs and toggle IPFS Companion to On
  3. wait a bit
  4. on the interstitial page that loads, click any of the buttons/links

They don't work; in fact, as noted, the white button on the bottom isn't even a clickable button for Gateway as it is in English.

french-ipfs

Capture d’écran 2021-06-17 à 2 13 39 PM

@stephendonner
Copy link

stephendonner commented Jun 30, 2021

Verified PASSED using

Brave 1.28.37 Chromium: 91.0.4472.124 (Build officiel) nightly (x86_64)
Révision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
Système d'exploitation macOS Version 11.4 (assemblage 20F71)

Pre-requisities:

Set OS language to French, and do so in Brave, too, at brave://settings/languages

Steps:

  1. new profile
  2. went to brave://settings/ipfs and toggled IPFS Companion to On
  3. clicked the French equivalent of Install extension / OK on the next dialog
  4. on the interstitial page that loaded, clicked on Utiliser un noeud local (Use a local node)
  5. also repeated steps 1-4, substituting Utiliser une passerelle publique (Use a public gateway)

Confirmed IPFS Companion 2.19.1 was installed, and worked

Use a local node Use public gateway
ipfs-french-fixed ipfs-french-fixed-gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment