Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser crash in private window #16041

Closed
ATrogolo opened this issue May 22, 2021 · 6 comments
Closed

Browser crash in private window #16041

ATrogolo opened this issue May 22, 2021 · 6 comments
Assignees
Labels
closed/duplicate Issue has already been reported crash OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@ATrogolo
Copy link

ATrogolo commented May 22, 2021

Description

When opening a new Private window and try to search something in the search bar the browser crash.

Steps to Reproduce

  1. Open Brave with couple of tabs
  2. Open a new Private Window
  3. Search something in the search bar
  4. The browser will crash

Actual result:

image

Expected result:

It shouldn't crash..

Reproduces how often:

Always

Brave version (brave://version info)

Brave: 1.24.86 Chromium: 90.0.4430.212 (Build ufficiale) (a 64 bit)
Revision: e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Don't know
  • Can you reproduce this issue with the nightly channel? Don't know

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NO
  • Does the issue resolve itself when disabling Brave Rewards? NO
  • Is the issue reproducible on the latest version of Chrome? Don't know

Miscellaneous Information:

image

@rebron rebron added crash priority/P2 A bad problem. We might uplift this to the next planned release. labels May 25, 2021
@bsclifton
Copy link
Member

bsclifton commented May 25, 2021

@ATrogolo is your search engine set by an extension? Maybe you can check brave://extensions

@simonhong recently pushed a fix for that type of crash which isn't on Release channel yet (it's on Beta). Fix was with brave/brave-core#8626

@simonhong
Copy link
Member

simonhong commented May 26, 2021

If this crash didn't come from search provider extension, this could be also related with #15707

@simonhong simonhong self-assigned this May 26, 2021
@ATrogolo
Copy link
Author

Hi @bsclifton ,
I'm using DuckDuckGo as search engine and the DuckDuckGo Privacy Essentials extension.
Disabling the extension the problem didn't happen.

@simonhong
Copy link
Member

Thanks @ATrogolo for your info.
Crashes from extension was fixed and that fix is on beta now as @bsclifton mentioned above.
Will close this issue.

@simonhong simonhong added the closed/duplicate Issue has already been reported label May 26, 2021
@ATrogolo
Copy link
Author

Ok, thanks!
@simonhong the issue will be fixed in the stable channel on 1.26 milestone (https://github.com/brave/brave-core/milestone/139)?
Alternatively, where can I check the version which will include a Brave fix (in the stable channel)?

@simonhong
Copy link
Member

@ATrogolo Yes, 1.26 will have this crash fix -
You can check the revision of the fix PR - brave/brave-core#8626
From this page(brave/brave-core@e4316b3),
that fix is included from 1.26.22
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported crash OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
None yet
Development

No branches or pull requests

4 participants