Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in IPFS log message: s/migragion/migration #16128

Closed
stephendonner opened this issue May 28, 2021 · 4 comments
Closed

Typo in IPFS log message: s/migragion/migration #16128

stephendonner opened this issue May 28, 2021 · 4 comments

Comments

@stephendonner
Copy link

Description

Typo in IPFS log message: s/migragion/migration

Steps to Reproduce

Not sure the actual steps to reproduce, here, yet.

Launching nightly with --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --use-dev-goupdater-url might yield it.

Actual result:

Could not add migragion to IPFS: nothing downloaded by ipfs fetcher

Screen Shot 2021-05-28 at 8 52 27 AM

Expected result:

Could not add migration to IPFS: nothing downloaded by ipfs fetcher

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.26 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

/cc @spylogsster

@spylogsster
Copy link

@lidel seems daemon issue

@lidel
Copy link

lidel commented May 31, 2021

Correct, it is a typo on our end, the fix is in ipfs/kubo#8167

@stephendonner
Copy link
Author

Confirmed fixed using 0.9.1 of go-ipfs on

Brave 1.30.15 Chromium: 92.0.4515.131 (Official Build) nightly (x86_64)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS macOS Version 11.5.2 (Build 20G95)

Screen Shot 2021-08-11 at 4 03 19 PM

Now reads Could not add migration to IPFS: nothing downloaded by ipfs fetcher.

@stephendonner
Copy link
Author

(Fixed by non-Chromium upstream - not sure the best resolution/label for this issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants