Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab keeps opening SI #16263

Closed
srirambv opened this issue Jun 7, 2021 · 1 comment · Fixed by brave/brave-core#9029
Closed

New tab keeps opening SI #16263

srirambv opened this issue Jun 7, 2021 · 1 comment · Fixed by brave/brave-core#9029

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 7, 2021

Description

New tab keeps opening SI

Steps to reproduce

  1. Install 1.26.53 Beta build
  2. Open a new tab
  3. Open a SI tab and group them together
  4. Open a new tab in the tab-group, keeps opening SI instead of normal image on new tab

Actual result

Android.ARM.SI.Tab-group.mp4

Expected result

Open SI as per rule every 4th tab

Issue reproduces how often

Easy-ish

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Not sure maybe
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Mostly yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.26.53 Beta Build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @samartnik

@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.26.63 x64 build

  • Verified steps from issue description
  • Verified in a tab group SI is only shown every 4th tab
  • Verified SI is opened every 4th tab even on normal tabs which are not part of tab-group
Android.Tab-Group.SI.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants