Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Block trackers & ads & Block cross-site trackers titles to be same similar to desktop #16299

Closed
srirambv opened this issue Jun 9, 2021 · 2 comments · Fixed by brave/brave-core#9240
Assignees
Labels
feature/global-settings Settings at browser level independent of shields settings feature/user-interface All UI related needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include suggestion

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 9, 2021

Description

Update Block trackers & ads & Block cross-site trackers titles to be same similar to desktop

Steps to reproduce

  1. Install 1.27.50 or 1.26.x build
  2. Open global shields settings, reads Block trackers & ads
  3. Visit a page and open shields, reads Block cross-site trackers

Actual result

image image

Expected result

Same naming convention similar to desktop

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.26.x & 1.27.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @karenkliu @anthonypkeane @jamesmudgett

@srirambv srirambv added needs-text-change This change requires some careful wording. suggestion feature/user-interface All UI related feature/global-settings Settings at browser level independent of shields settings OS/Android Fixes related to Android browser functionality labels Jun 9, 2021
@karenkliu
Copy link

karenkliu commented Jun 9, 2021

I thought we brought Android up to desktop parity with this issue? #7487 cc @anthonypkeane

The trackers & ads toggle in Shields should now be an expand option that the user can tap to get more options.

image

@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.27.105 x64 build

  • Verified steps from issue description
image image image

Verification passed on Samsung Tab A with Android 10 running 1.27.105 x64 build

  • Verified steps from issue description
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings feature/user-interface All UI related needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants