Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site level shield setting doesn't allow sub options for Standard/Aggressive/Allow all #16300

Closed
srirambv opened this issue Jun 9, 2021 · 4 comments · Fixed by brave/brave-core#9240
Assignees
Labels
enhancement feature/shields/adblock Blocking ads & trackers with Shields feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 9, 2021

Description

Site level ad-blocker doesn't allow sub options for Standard/Aggressive/Allow all

Steps to reproduce

  1. Install 1.26.53
  2. Allows to set ads blocking to Standard/Aggressive/Allow all in global shields settings
  3. Visit a page and open shields, no such option to change via shields for a particular site

Actual result

image image

Expected result

Should allow granular options for ad blocker similar to Fingerprint and Cookies

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): AEM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.26.53 Beta & 1.27.50 Nightly

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @deeppandya @karenkliu @anthonypkeane @SergeyZhukovsky

@srirambv srirambv added enhancement feature/shields/adblock Blocking ads & trackers with Shields QA/Yes release-notes/include feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality labels Jun 9, 2021
@karenkliu
Copy link

karenkliu commented Jun 9, 2021

Did we not update the Shields options to match desktop as part of #7487 ? cc @anthonypkeane

The trackers & ads, cookie blocking, and fingerprinting all need to have options available in settings:

image

@acatarineu
Copy link

@karenkliu Not sure you wanted to cc me :)

@karenkliu
Copy link

karenkliu commented Jun 9, 2021

@acatarineu Oops, sorry, yeah wrong person!

@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.27.105 x64 build

  • Verified site shields settings has the same options for Ads/Trackers blocked as in global settings
image image

Verification passed on OnePlus 6T with Android 10 running 1.27.105 x64 build

  • Verified site shields settings has the same options for Ads/Trackers blocked as in global settings
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/shields/adblock Blocking ads & trackers with Shields feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants