Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to revert #13190 clickable sponsored image #16351

Closed
rebron opened this issue Jun 10, 2021 · 1 comment · Fixed by brave/brave-core#9074
Closed

Follow-up to revert #13190 clickable sponsored image #16351

rebron opened this issue Jun 10, 2021 · 1 comment · Fixed by brave/brave-core#9074

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 10, 2021

Description

Feedback on clickable sponsored image is showing too many mistaken clickthroughs. Need to revert #13190 to go back to only the NTPSI logo as the clickable item for the NTPSI sponsorship.

Steps to Reproduce

  1. Click anywhere on NTP page (which has a NTPSI) that's not one of the widgets, e.g. near bookmarks toolbar.
  2. Notice the clickthrough for the NTPSI.

Actual result:

Expected result:

Clicking anywhere on the NTPSI image should not clickthrough to NTSPI destination, only when clicking the NTPSI logo.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issue: #13190

@stephendonner
Copy link

stephendonner commented Jun 16, 2021

Verified PASSED using

Brave 1.26.63 Chromium: 91.0.4472.106 (Official Build) (x86_64)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. opened a few new-tab pages
  4. on one with a sponsored image, confirmed the following:
  • sponsored image is in the bottom-left corner
  • when hovered over, see a tooltip with the call to action of Nexo - Unlock the Power of Your Crypto. Sign up at nexo.io
  • a little box-with-arrow icon shows up on the top-right of the image
  • link URL is https://nexo.io/?utm_source=brave&utm_medium=fixed&utm_campaign=brave_nts_apr21
  • confirmed clicking on the link loads https://nexo.io/?utm_source=brave&utm_medium=fixed&utm_campaign=brave_nts_apr21
  • confirmed no other click targets for the sponsored image
  • confirmed clicking on Customize and toggling Show Sponsored Images to Off no longer shows them on new-tab pages
  • conversely, confirmed toggling Show Sponsored Images back to On again shows them on every 4th new-tab page
  • confirmed pref state for Show Sponsored Images (on/off) is honored when upgrading from 1.25.73 to 1.26.63
example example example
Screen Shot 2021-06-16 at 3 27 58 PM Screen Shot 2021-06-16 at 3 34 52 PM Screen Shot 2021-06-16 at 3 37 54 PM

Verification passed on

Brave 1.26.63 Chromium: 91.0.4472.106 (Official Build) (64-bit)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS Ubuntu 18.04 LTS

16351


Verification passed on

<!--StartFragment-->
Brave | 1.26.63 Chromium: 91.0.4472.106&nbsp;(Official Build)&nbsp;(64-bit)
-- | --
Revision | 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.1052)

<!--EndFragment-->

Verified the STR from the description and confirmed the following:

  • sponsored image link is in the bottom-left corner
  • when hovered over, see a tooltip with the call to action of "The Motley Fool - Start building wealth today. New members get 50% off Motley Fool's stock-picking service. Missing out? Join now."
  • a little box-with-arrow icon shows up on the top-right of the image
  • link URL is https://www.fool.com/ecap/today-motley-fool-is-offering-new-members-50-off-i/?utm_source=brave&utm_medium=contentmarketing&utm_campaign=sar-sadirect-short&aid=8893&paid=8893&waid=8893&source=esabvewdg0310002&psource=esabvewdg0310002&wsource=esabvewdg0310002&testId=e-sa-direct&cellId=1&campaign=sa-release-evergreen
  • confirmed clicking on the link loads https://www.fool.com/ecap/today-motley-fool-is-offering-new-members-50-off-i/?utm_source=brave&utm_medium=contentmarketing&utm_campaign=sar-sadirect-short&aid=8893&paid=8893&waid=8893&source=esabvewdg0310002&psource=esabvewdg0310002&wsource=esabvewdg0310002&testId=e-sa-direct&cellId=1&campaign=sa-release-evergreen
  • confirmed no other click targets for the sponsored image
  • confirmed clicking on Customize and toggling Show Sponsored Images to Off no longer shows them on new-tab pages
  • conversely, confirmed toggling Show Sponsored Images back to On again shows them on every 4th new-tab page
  • confirmed pref state for Show Sponsored Images (on/off) is honored when upgrading from 1.25.73 to 1.26.63
example example example
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants