Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing comma from "anonymous online, though." under Private Window #1649

Closed
kjozwiak opened this issue Oct 17, 2018 · 2 comments
Closed

removing comma from "anonymous online, though." under Private Window #1649

kjozwiak opened this issue Oct 17, 2018 · 2 comments

Comments

@kjozwiak
Copy link
Member

Description

Remove the comma from Private Windows don’t make you completely anonymous online, though..

Steps to Reproduce

  1. open 0.55.16 Chromium: 70.0.3538.54
  2. open a Private Window
  3. notice the , after online and before though

Actual result:

screen shot 2018-10-17 at 2 27 26 am

Expected result:

Remove the comma.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Pretty sure dev and beta are also affected but currently don't have a build from those channels that includes the new brave://newtab work.

  • Does it reproduce on browser-laptop?

N/A

Additional Information

CCing @bsclifton @bbondy @rebron

@rebron
Copy link
Collaborator

rebron commented Oct 17, 2018

Also need a comma after history.
current: "Sites you visit won't show up in your history and cookies vanish when you’re done."
should be: "Sites you visit won't show up in your history, and cookies vanish when you’re done."

@bsclifton bsclifton modified the milestones: 1.0, Dupe / Invalid / Not actionable Oct 18, 2018
@bsclifton
Copy link
Member

Friendly reminder 😄 Please be sure to change the milestone when closing issues (ex: since this is won't fix, we can mark as Dupe / Invalid / Not actionable)

@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants