-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add province-level targeting for Canada + US-Wyoming #16682
Comments
We have also been approved to include US-WY (Wyoming) as well. |
@iambrianfung US-WY is already part of the ads library. Removing from description. Thanks |
Verification passed on
Verified test plan from brave/brave-core#15009 Case 1US-CA CA-QC Verified fetching of ads subdivision target was scheduled
Verified fetching of ads subdivision target was scheduled
Verified ads subdivision target is fetched when scheduled
Case 2US-CA CA-QC Case 3CA-QC Run brave in Polish locale (PL) ad relevance is available CA-QC Case 4
Verified `United States-Oregon` ad is served for `United States-Oregon`
```
[22903:22903:1021/122619.839189:VERBOSE1:eligible_notification_ads_v1.cc(191)] 2 eligible ads out of 2 ads for untargeted segment
[22903:22903:1021/122619.839300:VERBOSE1:notification_ad.cc(135)] Opportunity arose to serve a notification ad
[22903:22903:1021/122619.839695:VERBOSE1:notification_ad_serving.cc(125)] Found 2 eligible ads
[22903:22903:1021/122619.839821:VERBOSE1:notification_ad_serving.cc(193)] Served notification ad:
placementId: 8cf8f8ed-47ac-4e7f-82db-be4b3d78900d
creativeInstanceId: d402c3dd-416f-4f47-952a-fa2429d4d951
creativeSetId: 0d0aade3-3a1f-4a64-bd99-a12e65fea771
campaignId: b9e77868-b83b-4c48-8631-9dbd0737c153
advertiserId: 2318807a-a4bb-4b81-bbc8-abd71af01800
segment: untargeted
title: United States-Oregon
body: United States-Oregon
targetUrl: https://odos.xyz/
```
Case 5
Verified `Canada-Quebec` ad is served for `Canada-Quebec`
```
[26471:26471:1021/133101.547807:VERBOSE1:eligible_notification_ads_v1.cc(191)] 1 eligible ads out of 2 ads for untargeted segment
[26471:26471:1021/133101.548364:VERBOSE1:notification_ad.cc(135)] Opportunity arose to serve a notification ad
[26471:26471:1021/133101.549383:VERBOSE1:notification_ad_serving.cc(125)] Found 1 eligible ads
[26471:26471:1021/133101.549914:VERBOSE1:notification_ad_serving.cc(193)] Served notification ad:
placementId: 740325f9-fb76-422b-8ae4-c2593ee7e119
creativeInstanceId: d402c3dd-416f-4f47-952a-fa2429d4d951
creativeSetId: 0d0aade3-3a1f-4a64-bd99-a12e65fea771
campaignId: b9e77868-b83b-4c48-8631-9dbd0737c153
advertiserId: 2318807a-a4bb-4b81-bbc8-abd71af01800
segment: untargeted
title: Canada-Quebec
body: Canada-Quebec
targetUrl: https://odos.xyz/
|
Verified on
Used Test Plan in brave/brave-core#15009 (comment) as reference Case 1 -
|
Description
Add province-level targeting for Canadian Provinces
Include
['CA-AB', 'Alberta'],
['CA-BC', 'British Columbia'],
['CA-MB', 'Manitoba'],
['CA-NB', 'New Brunswick'],
['CA-NS', 'Nova Scotia'],
['CA-ON', 'Ontario'],
['CA-QC', 'Quebec'],
['CA-SK', 'Saskatchewan']
Exclude the following provinces
'CA-NL', 'Newfoundland & Labrador'
'CA-PE', 'Prince Edward Island'
'CA-NT', 'Northwest Territories'
'CA-YT', 'Yukon'
'CA-NU', 'Nunavut'
iOS does not show the UI at this time; however, we should raise a separate issue for iOS just in case the functionality is re-enabled in the future
The text was updated successfully, but these errors were encountered: