Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change WebRTC learn more link from article on github to article on support site #1690

Closed
rebron opened this issue Oct 18, 2018 · 2 comments · Fixed by brave/brave-core#748
Closed

change WebRTC learn more link from article on github to article on support site #1690

rebron opened this issue Oct 18, 2018 · 2 comments · Fixed by brave/brave-core#748
Assignees
@Brave-Matt @yrliou
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include support addition/edits to articles on support website
Milestone
0.56.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 18, 2018

Learn More link under WebRTC points to github doc: https://github.com/brave/brave-browser/wiki/WebRTC-Custom-Settings

Move content to support web site and change link to point to that new article.
@rebron rebron modified the milestone: FROZEN: 0.55.x - Release Oct 18, 2018
@rebron rebron added this to the 0.56.x - Beta milestone Oct 18, 2018
@rebron rebron added documentation ✍️ support addition/edits to articles on support website and removed documentation ✍️ labels Oct 18, 2018
@rebron rebron changed the title move WebRTC learn more link to support article change WebRTC learn more link from article on github to article on support site Oct 18, 2018
@rebron rebron assigned yrliou and unassigned yrliou Oct 26, 2018
@rebron
Copy link
Collaborator Author

rebron commented Oct 26, 2018 •
edited
Loading

new link in support: https://support.brave.com/hc/en-us/articles/360017989132-How-do-I-change-my-Privacy-Settings-#webrtc

updated with anchor tag/better link

@yrliou yrliou mentioned this issue Oct 26, 2018
Merged
18 tasks
@yrliou yrliou added the QA/Yes label Oct 26, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Oct 31, 2018 •
edited by srirambv
Loading

Verified passed with

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Verification Passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Verification Passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

@kjozwiak kjozwiak mentioned this issue Nov 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brave-Matt Brave-Matt

@yrliou yrliou

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include support addition/edits to articles on support website
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Update WebRTC support URL brave/brave-core
7 participants
@kjozwiak @Brave-Matt @yrliou @rebron @srirambv @LaurenWags @GeetaSarvadnya