Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "x BAT arriving in y days" text to emphasize that payouts will begin by that time #17943

Closed
Miyayes opened this issue Sep 8, 2021 · 9 comments · Fixed by brave/brave-core#10240
Assignees
Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 8, 2021

Description

Currently, we say "2.1 BAT arriving in 3 days" messaging upon a new month. However, payout team usually only starts payout processing on that date, and payouts (especially to verified users) can take a couple days to all process due to transaction times on various exchanges/custodians. We should change text to reflect this, as there is still user confusion.

OR, the payout team can adjust payout date to catch the end/completion of payouts. However, some users will see this messaging even though they've already received their payout (since transactions are sequentially processed). cc: @aekeus

image

Solution

Main message: Your X BAT payout will begin processing in Y Days.
Subtext (fine print): Note: It can take a few days for the payout to process and your BAT to arrive.

image

cc: @jonathansampson

@Miyayes Miyayes added needs-text-change This change requires some careful wording. feature/rewards OS/Desktop labels Sep 8, 2021
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 8, 2021
@rmcfadden3
Copy link

Per sidebar in Slack, here's our winner:

Main message: Your X BAT payout will begin processing in Y Days.
Subtext (fine print): Note: It can take a few days for the payout to process and your BAT to arrive.

@rmcfadden3 rmcfadden3 removed their assignment Sep 8, 2021
@Miyayes Miyayes assigned ghost Sep 8, 2021
@Miyayes Miyayes added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Sep 8, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Sep 20, 2021

image

@Miyayes Miyayes assigned zenparsing and unassigned ghost Sep 20, 2021
@Miyayes Miyayes removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Sep 20, 2021
@emerick emerick self-assigned this Sep 20, 2021
@rmcfadden3
Copy link

Nice! Messaging seems to fit the design OK.

@emerick
Copy link
Contributor

emerick commented Sep 22, 2021

@Miyayes Do we want to skip the "fine print" note on the Rewards widget version? Seems like it will get cramped there, but let me know.

@Miyayes
Copy link
Collaborator Author

Miyayes commented Sep 23, 2021

@emerick Good point. We can skip it for now, especially as zenparsing will be reworking Rewards NTP Widget v2. Will keep an eye out on user feedback.

@stephendonner
Copy link

Verified PASSED using

Brave 1.32.74 Chromium: 95.0.4638.54 (Official Build) dev (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave
  3. enabled Rewards
  4. viewed some ads
  5. opened brave://rewards and noted the Next payment date
  6. shut down Brave
  7. time traveled to 3 days before the payout date
  8. reopened brave://rewards and a new-tab page
  9. confirmed messaging changes:

brave://rewards:

Your +0.03 BAT payout will begin processing in 3 days.
Note: It can take a few days for the payout to process and your BAT to arrive.

New-tab page:

Your +0.03 BAT payout will begin processing in 3 days.
brave://rewards new-tab page
Screen Shot 2021-11-02 at 3 35 56 PM Screen Shot 2021-11-02 at 3 36 00 PM

@LaurenWags
Copy link
Member

@Miyayes @emerick the test plan in brave/brave-core#10240 doesn't mention any wording changes on the panel. This is what I'm seeing on the panel with 1.32.x, is this expected?

Panel Summary View Panel Creator View
Screen Shot 2021-11-01 at 12 08 31 PM Screen Shot 2021-11-01 at 12 08 50 PM

On brave://rewards and NTP widget I see the same as @stephendonner above, which matches the test plan:

brave://rewards NTP widget
Screen Shot 2021-11-01 at 12 09 18 PM Screen Shot 2021-11-01 at 12 09 08 PM
Brave | 1.32.78 Chromium: 95.0.4638.54 (Official Build) beta (x86_64)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | macOS Version 11.6 (Build 20G165)

@emerick
Copy link
Contributor

emerick commented Oct 25, 2021

@LaurenWags Yes, that's my fault for not pointing that out. We simplified the text a little on that screen to try to avoid the need for two lines.

@LaurenWags
Copy link
Member

thanks @emerick, glad it's expected 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants