Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Search Engine screen from onboarding for CA / DE / FR / GB / US #18452

Closed
bsclifton opened this issue Sep 29, 2021 · 2 comments · Fixed by brave/brave-core#10326
Closed

Remove Search Engine screen from onboarding for CA / DE / FR / GB / US #18452

bsclifton opened this issue Sep 29, 2021 · 2 comments · Fixed by brave/brave-core#10326
Assignees
@deeppandya
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Blocked QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.31.x - Release

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 29, 2021 •
edited
Loading

Test plan

See #18331

Description

Android counterpart to #18415

Depends on #18331

Please see details here: https://github.com/brave/internal/issues/816
@bsclifton bsclifton added the OS/Android Fixes related to Android browser functionality label Sep 29, 2021
@bsclifton bsclifton mentioned this issue Sep 29, 2021
Merged
24 tasks
@bsclifton bsclifton added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes release-notes/include labels Sep 29, 2021
@bsclifton bsclifton mentioned this issue Sep 30, 2021
Closed
@bsclifton bsclifton mentioned this issue Oct 5, 2021
Merged
7 tasks
@bsclifton bsclifton added this to the 1.32.x - Nightly milestone Oct 5, 2021
@brave-builds brave-builds mentioned this issue Oct 5, 2021
Merged
7 tasks
@kjozwiak kjozwiak mentioned this issue Oct 11, 2021
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Oct 13, 2021 •
edited
Loading

Adding QA/Blocked as the above will require a 1.31.x RC which I'm hoping to kick off tonight 👍 We'll need 1.31.84 or higher.

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 11 running 1.31.86 x64 build

Verification passed on Samsung Tab A with Android 10 running 1.31.86 x64 build

@kjozwiak kjozwiak mentioned this issue Nov 2, 2021
Closed
@rebron rebron mentioned this issue Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Blocked QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Update default search for 5 regions brave/brave-core
4 participants
@kjozwiak @bsclifton @deeppandya @srirambv