Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable window.ethereum on Incognito and Tor private windows for now #18455

Closed
bbondy opened this issue Sep 30, 2021 · 0 comments · Fixed by brave/brave-core#10367
Closed

Disable window.ethereum on Incognito and Tor private windows for now #18455

bbondy opened this issue Sep 30, 2021 · 0 comments · Fixed by brave/brave-core#10367
Assignees
@SergeyZhukovsky
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.32.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Sep 30, 2021 •
edited
Loading

We may want to enable this later, but we'll do a separate security review for that if so.

It should act like the None setting for either of these window types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Allow web3 on regular profiles only brave/brave-core
2 participants
@bbondy @SergeyZhukovsky