Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Settings icons for ipfs and wallet use static color, not dynamic #18775

Closed
petemill opened this issue Oct 14, 2021 · 2 comments · Fixed by brave/brave-core#10521
Closed

[Desktop] Settings icons for ipfs and wallet use static color, not dynamic #18775

petemill opened this issue Oct 14, 2021 · 2 comments · Fixed by brave/brave-core#10521
Assignees
@petemill
Labels
feature/web3/ipfs feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.32.x - Release

Comments

@petemill
Copy link
Member

Description

As reported by @srirambv
image
@petemill petemill self-assigned this Oct 14, 2021
@petemill petemill mentioned this issue Oct 14, 2021
Merged
24 tasks
@petemill petemill added this to the 1.33.x - Nightly milestone Oct 14, 2021
@petemill petemill mentioned this issue Oct 15, 2021
Merged
@stephendonner
Copy link

Verified PASSED using

Brave 1.32.74 Chromium: 95.0.4638.54 (Official Build) dev (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS macOS Version 11.6 (Build 20G165)

Confirmed in both dark and light modes that hover and selected states have the appropriate styling.

example example example example
Screen Shot 2021-10-22 at 10 10 05 AM Screen Shot 2021-10-22 at 10 10 21 AM Screen Shot 2021-10-22 at 10 05 43 AM Screen Shot 2021-10-22 at 10 08 30 AM

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.32.76 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
  • Linux
  • Windows
  • macOS
Wallet Light Theme
IPFS Light Theme
Wallet Dark Theme
IPFS Dark Theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/web3/ipfs feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release
4 participants
@stephendonner @petemill @kjozwiak @srirambv