Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to hosts filter lists using the format 0.0.0.0 [domain] to block #18876

Closed
Diego-BF opened this issue Oct 19, 2021 · 0 comments
Closed

Comments

@Diego-BF
Copy link

Description

When the host filter list uses the format 0.0.0.0 [blocked_domain], urls from the domains/subdomains in the list aren't blocked. Example of list that uses this format is https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts .

Steps to Reproduce

  1. Add some list that uses the format 0.0.0.0 [blocked_domain];
  2. Access some site that have the urls from the blocked domain/subdomain as a first or third party.

Actual result:

The url from the domain/subdomain isn't blocked by Brave, either as a first or third party.

Expected result:

The url from the domain/subdomain is blocked by Brave, either as a first or third party.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.31.87 Chromium: 95.0.4638.54 (Official Build) (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Linux

Miscellaneous Information:

The filter list https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts use this format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants