Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove payout status banners ("X BAT will arrive in y days" notices) for unverified users once they claim #19253

Closed
Miyayes opened this issue Nov 6, 2021 · 3 comments
Closed

Remove payout status banners ("X BAT will arrive in y days" notices) for unverified users once they claim #19253

Miyayes opened this issue Nov 6, 2021 · 3 comments
Labels
feature/rewards OS/Desktop payouts priority/P4 Planned work. We expect to get to it "soon".

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Nov 6, 2021 •
edited
Loading

Description

Suppose payment date is Nov 7. Sometimes, virtual-BAT ad earnings become available a little earlier (e.g., Nov 5). Then, even though users have already claimed the BAT, the notice/countdown persists until Nov 7.

This occurred in Nov 2021, for example:

Solution

When user claims, clear countdown notice (@jsecretan). This basically only applies to unverified users, since verified users don't go through the claim process.
@Miyayes Miyayes changed the title Remove "Payout will begin processing" notices for unverified users once they claim Remove "Payout will begin processing in x days" notices for unverified users once they claim Nov 6, 2021
@Miyayes Miyayes changed the title Remove "Payout will begin processing in x days" notices for unverified users once they claim Remove "X BAT will begin processing in y days" notices for unverified users once they claim Nov 6, 2021
@Miyayes Miyayes mentioned this issue Nov 8, 2021
Closed
@Miyayes Miyayes added the payouts label Nov 9, 2021
@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 10, 2021
@Miyayes Miyayes changed the title Remove "X BAT will begin processing in y days" notices for unverified users once they claim Remove "X BAT will arrive in y days" notices for unverified users once they claim Nov 11, 2021
@Miyayes Miyayes changed the title Remove "X BAT will arrive in y days" notices for unverified users once they claim Remove payout status banners ("X BAT will arrive in y days" notices) for unverified users once they claim Nov 12, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jan 26, 2022 •
edited
Loading

I believe this is superseded by #18602. Feel free to re-open if that's not the case.

@Miyayes Miyayes closed this as completed Jan 26, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Jan 26, 2022 •
edited
Loading

@Miyayes I am not sure this is true.

afaik #18602 is still date based, so if grant arrives on 5th and user claims, I think the pending message still shows until the 7th, at which point it will change to the "Arrived" messaging. @zenparsing should double check me on this though.

@LaurenWags LaurenWags reopened this Jan 26, 2022
@zenparsing zenparsing added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 16, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jul 17, 2022 •
edited
Loading

Will this be superseded by #23429 @emerick?

@Miyayes Miyayes closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/rewards OS/Desktop payouts priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zenparsing @Miyayes @LaurenWags