Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable wallet by default, disable Dapps #19702

Closed
SergeyZhukovsky opened this issue Nov 24, 2021 · 1 comment · Fixed by brave/brave-core#11263
Closed

Enable wallet by default, disable Dapps #19702

SergeyZhukovsky opened this issue Nov 24, 2021 · 1 comment · Fixed by brave/brave-core#11263
Assignees
@SergeyZhukovsky
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.33.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

No description provided.

@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Nov 24, 2021
@SergeyZhukovsky SergeyZhukovsky self-assigned this Nov 24, 2021
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Nov 24, 2021
Merged
24 tasks
@SergeyZhukovsky SergeyZhukovsky added this to the 1.34.x - Nightly milestone Nov 24, 2021
This was referenced Dec 3, 2021
Closed
Merged
@kjozwiak kjozwiak added QA/Yes and removed QA/No labels Dec 8, 2021
@srirambv
Copy link
Contributor

srirambv commented Dec 9, 2021 •
edited
Loading

Verification passed on Samsung Tab A with Android 10 running 1.33.103 x64 build

  • Verified Wallet is enabled by default
  • Verified able to create wallet successfully
  • Verified able to restore wallet successfully
  • Verified visiting a Dapp doesn't trigger wallet connection

Verification passed on Oppo Reno 5 with Android 11 running 1.33.103 x64 build

  • Verified Wallet is enabled by default
  • Verified able to create wallet successfully
  • Verified able to restore wallet successfully
  • Verified visiting a Dapp doesn't trigger wallet connection

@kjozwiak kjozwiak mentioned this issue Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Enables wallet on Android by default, disables Dapps brave/brave-core
3 participants
@kjozwiak @SergeyZhukovsky @srirambv