Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore open search behaviour for Android #19737

Closed
samartnik opened this issue Nov 25, 2021 · 1 comment · Fixed by brave/brave-core#11293
Closed

Restore open search behaviour for Android #19737

samartnik opened this issue Nov 25, 2021 · 1 comment · Fixed by brave/brave-core#11293

Comments

@samartnik
Copy link
Contributor

samartnik commented Nov 25, 2021

Description

Recent PR brave/brave-core#9602 caused a regression in Android behavour, we need to restore it until we figure out what we want to do with this option.

Steps to reproduce

  1. On Android, visit a search engine and perform a search (user used searx.be)
  2. After performing the search, check Settings --> Search engines --> Recently visited and observe no searches have been added

Actual result

No recently visited search engines.

Expected result

There should be recently visited search engines.

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv
Copy link
Contributor

srirambv commented Dec 6, 2021

Verification passed on the following devices running 1.33.114 x64 build

  • Verified steps from issue description
  • Verified performing a search on a page that supports open search gets listed under Recently visited
  • Verified able to select the search engine added via open search and set it as default
  • Verified open search engine gets listed for both normal and private search engine settings
  • Verified able to switch back to default list which moves the added search engine back to recently visited list
Oppo Reno 5 (Android 11) Samsung Tab A (Android 10)
Open.Search.Android.ARM.mp4
Open.Search.Android.Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants