Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Biometric unlock not coming up when autolock happens within wallet #20036

Closed
bbondy opened this issue Dec 10, 2021 · 1 comment · Fixed by brave/brave-core#11735
Closed

Biometric unlock not coming up when autolock happens within wallet #20036

bbondy opened this issue Dec 10, 2021 · 1 comment · Fixed by brave/brave-core#11735
Labels
android-phone-specific feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Dec 10, 2021

Steps to reproduce:

  • Go to wallet
  • Lock your phone for 5 minutes
  • Unlock your phone

Your wallet will go to the lock screen but no biometric button is present.

Expected:
It should be on the lock screen as it is, but there should be a way for biometric to come up. Users don't want to have to type a long password.

Workaround:
Users can do a workaround if they experience this to go out of the wallet, then click on the wallet menu again, then it will come up. But that is extra steps so not good UX.
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality labels Dec 10, 2021
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 4, 2022
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing added this to the 1.36.x - Nightly milestone Jan 10, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 7, 2022

Verification passed on Oppo Reno 5 with Android 11 running 1.36.85 x64 beta build

  • Verified steps from issue description
  • Verified bio-metric unlock option shows up on lock screen irrespective of how the wallet is locked

@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 3, 2022
@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android-phone-specific feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): add fingerprint icon to unlock brave/brave-core
3 participants
@bbondy @Pavneet-Sing @srirambv