Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EVM compatible chains #20337

Closed
SergeyZhukovsky opened this issue Jan 5, 2022 · 2 comments · Fixed by brave/brave-core#11822
Closed

Support EVM compatible chains #20337

SergeyZhukovsky opened this issue Jan 5, 2022 · 2 comments · Fixed by brave/brave-core#11822
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

No description provided.

@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 5, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jan 5, 2022
@SergeyZhukovsky SergeyZhukovsky added this to the 1.36.x - Nightly milestone Jan 12, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 7, 2022

Verification PASSED on Samsung GS 21 running Android 12 using build version:

1.36.86, Chromium 98.0.4758.87

Verified Acceptance Criteria:

  • User is able to add custom EVM compatible networks - 5efd665
  • Buy/Swap action button options hidden when a custom network is selected - adb5c84
  • Custom networks are displayed in dropdown after getting added in the settings
  • User is able to remove custom networks in the settings
  • User can edit custom networks in the settings
  • User is able to set network as active in the settings
  • User can edit visiable assets in the Portfolio tab for custom networks
  • Tapping Send when viewing asset details opens the send screen and selects the currency token for the network selected by default
Network Dropdown Buy/Swap hidden Network menu item
Screenshot_20220208-061741_Brave - Beta Screenshot_20220208-063636_Brave - Beta Screenshot_20220208-065231_Brave - Beta

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

Verification passed on Samsung Tab A with Android 10 running 1.36.87 x64 beta build

  • Verified steps from brave/brave-core#11822
  • Verified a new setting item is shown under Menu -> Brave Wallet -> Networks
  • Verified able to add a new custom network via wallet settings from wallet or via menu settings
  • Verified added custom networks show up on portfolio
  • Verified custom networks only has send transactions
  • Verified transaction approval shows up for custom EVM networks
  • Verified able to add multiple custom networks
  • Verified added custom networks are retained between restarts
  • Encountered #20967 & #20968
  • Verified correct error message is shown for each field
New Networks Setting Add network Network Details Add Network details Added Custom networks
image image image image image
Custom Network on Portfolio Select Custom Network Send only Transaction Approval Transaction Details
image image image image image
Chain ID Chain Name Chain Currency Chain Currency Symbol Decimal RPC Block Explorer
image image image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants