Error in getShieldSettingsForTabData should be handled

[jasonrsadler]

Description

When generating a page (e. g. print backup keys, etc) an error is generated.

Steps to Reproduce

1. Start Brave and create Rewards Wallet
2. Open advanced settings (backup/restore icon)
3. Under 'Backup your wallet' click print

Actual result:

Functionality for print keys proceeds as expected, however, an unhandled promise exception is thrown:

[6213:775:1107/200453.816830:INFO:CONSOLE(1)] "%cUnhandled rejection Error: No tab url specified
    at t.getShieldSettingsForTabData (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:30562)
    at l (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:110001)
    at I._settlePromiseFromHandler (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:83232)
    at I._settlePromise (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:84032)
    at I._settlePromise0 (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:84731)
    at I._settlePromises (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:86083)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:39533
From previous event:
    at I.B [as _captureStackTrace] (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:53021)
    at I._then (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:78689)
    at I.then (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:77037)
    at Object.t.requestShieldPanelData (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:32422)
    at _ (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:128956)
    at t.default (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:129722)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4091
    at v (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:2008)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:127981
    at Object.tabCreated (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4218)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:139530", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js (1)
[6213:775:1107/200453.818281:INFO:CONSOLE(1)] "%cUnhandled rejection Error: No tab url specified
    at t.getShieldSettingsForTabData (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:30562)
    at l (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:110001)
    at I._settlePromiseFromHandler (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:83232)
    at I._settlePromise (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:84032)
    at I._settlePromise0 (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:84731)
    at I._settlePromises (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:86083)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:39533
From previous event:
    at I.B [as _captureStackTrace] (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:53021)
    at I._then (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:78689)
    at I.then (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:77037)
    at Object.t.requestShieldPanelData (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:32422)
    at d (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:134577)
    at t.default (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:135439)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4091
    at v (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:2008)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:127981
    at Object.tabCreated (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4218)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:139530", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js (1)
[6213:775:1107/200453.819041:INFO:CONSOLE(1)] "%cUnhandled rejection Error: No tab url specified
    at t.getShieldSettingsForTabData (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:30562)
    at l (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:110001)
    at I._settlePromiseFromHandler (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:83232)
    at I._settlePromise (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:84032)
    at I._settlePromise0 (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:84731)
    at I._settlePromises (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:86083)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:39533
From previous event:
    at I.B [as _captureStackTrace] (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:53021)
    at I._then (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:78689)
    at I.then (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:77037)
    at Object.t.requestShieldPanelData (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:32422)
    at _ (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:128956)
    at t.default (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:129554)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4091
    at v (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:2008)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:127981
    at Object.activeTabChanged (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4218)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:139435", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js (1)
[6213:775:1107/200453.820939:INFO:CONSOLE(1)] "%cUnhandled rejection Error: No tab url specified
    at t.getShieldSettingsForTabData (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:30562)
    at l (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:110001)
    at I._settlePromiseFromHandler (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:83232)
    at I._settlePromise (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:84032)
    at I._settlePromise0 (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:84731)
    at I._settlePromises (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:86083)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:39533
From previous event:
    at I.B [as _captureStackTrace] (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:53021)
    at I._then (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:78689)
    at I.then (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:77037)
    at Object.t.requestShieldPanelData (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:32422)
    at d (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:134577)
    at t.default (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:135281)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4091
    at v (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:2008)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:127981
    at Object.activeTabChanged (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4218)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:139435", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js (1)

Expected result:

No exceptions are thrown

Reproduces how often:

always

Brave version (brave://version info)

Brave	0.59.1 Chromium: 71.0.3578.31 (Developer Build) (64-bit)
Revision	c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS	Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  No. (Print backup keys is not yet available on current release [0.55.x/0.56.x as of this writing])

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

Introduced here: https://github.com/brave/brave-core/pull/816/files#diff-aa81b445f3d957d5c028d1df07d3ac64R80

If this is intended functionality, please let me know and I'll correct the implementation.

*original discussion: brave/brave-core#816 (review)