Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Wallet / Brave Swap: Displaying Brave DEX Aggregator on Android #20463

Closed
lukemulks opened this issue Jan 12, 2022 · 5 comments · Fixed by brave/brave-core#11978
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include

Comments

@lukemulks
Copy link

Description

On mobile (confirmed on Android, uncertain on iOS), in the Swap feature, we reference the Brave DEX Aggregator. See image below.
Screenshot_20220111-162539_Brave

We should remove the Brave DEX Aggregator reference from the Swap feature text.

Something like "Swap tokens for tokens" or some such may work well to replce.

Steps to Reproduce

  1. Open Brave Wallet on mobile
  2. Tap Send/Receive/Swap <> arrow icon
  3. See Swap feature copy

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@lukemulks lukemulks added bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 12, 2022
@srirambv
Copy link
Contributor

Seems to be just mobile issue that was missed. Desktop uses Brave uses 0x as a DEX aggregator. on both widget and panel

Panel Widget
image image

@srirambv srirambv added OS/iOS Fixes related to iOS browser functionality and removed OS/Desktop labels Jan 12, 2022
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 19, 2022
@SergeyZhukovsky
Copy link
Member

@srirambv we have exactly the same text on a Swap screen on Android. The issue is about text before you go to a swap screen
Screenshot_20220125-111601_Brave - Debug

@Pavneet-Sing
Copy link

@srirambv this also has iOS label on it so could you please confirm if this is there on iOS?, then probably we will create an iOS issue for same. BTW, new label is "Swap tokens and assets".

@srirambv
Copy link
Contributor

srirambv commented Jan 28, 2022

@Pavneet-Sing yes this is an issue on iOS as well. Its only on the Buy/Send/Swap main screen not on the individual feature screen.

This is on iOS

I'll add an iOS specific issue as well iOS Specific issue brave/brave-ios#4911

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.37.89 x64 beta build

  • Verified Swap option now has the description of Swap tokens and assets
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants