Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor resets to starting position when Show recovery phrase is selected #20465

Closed
srirambv opened this issue Jan 12, 2022 · 1 comment · Fixed by brave/brave-core#11980
Closed

Cursor resets to starting position when Show recovery phrase is selected #20465

srirambv opened this issue Jan 12, 2022 · 1 comment · Fixed by brave/brave-core#11980
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Cursor resets to starting position when Show recovery phrase is selected

Steps to reproduce

  1. Start typing a restore seed
  2. Select the Show recovery phrase checkbox
  3. Cursor resets position to the beginning rather than where you left it while typing

Actual result

Cursor resets to starting position when Show recovery phrase is selected

Expected result

Retain cursor position

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: Al

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky @Pavneet-Sing @wchen342
@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 12, 2022
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 19, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 25, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 25, 2022
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing added this to the 1.36.x - Nightly milestone Jan 25, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Feb 7, 2022

Verification passed on Samsung Tab A with Android 10 running 1.36.85 x64 beta build

  • Verified steps from issue description
  • Verified selecting Show recovery phrase doesn't reset to starting position

Verification passed on Oppo Reno 5 with Android 11 running 1.36.85 x64 beta build

  • Verified steps from issue description
  • Verified selecting Show recovery phrase doesn't reset to starting position

@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): retain cursor position when showing/hiding recovery phrase brave/brave-core
4 participants
@bbondy @anthonypkeane @Pavneet-Sing @srirambv