Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import relevant settings from Brave Payments #2050

Closed
8 tasks done
davidtemkin opened this issue Nov 8, 2018 · 2 comments
Closed
8 tasks done

Import relevant settings from Brave Payments #2050

davidtemkin opened this issue Nov 8, 2018 · 2 comments

Comments

@davidtemkin
Copy link

davidtemkin commented Nov 8, 2018

Test plan

See brave/brave-core#736

Description

When a user is being upgraded from Muon/Brave Payments to Brave Core/Brave Rewards, the following settings should be carried over:

  • Minimum page time before logging a visit
  • Minimum visits for publisher relevancy
  • Allow contributions to non-verified sites
  • Allow contributions to videos

In the event of automatic/silent upgrade, all of these items should be automatically imported.

In the event of a manual import, following a manual download/install of Brave Core, these items should be imported whenever a user decides to import "Brave Payments data" (an option on the list that includes bookmarks, cookies, passwords, etc).

This is in addition to the import of the following items, covered elsewhere:

  • Wallet (this includes Grants; attached to wallet by way of server query)
  • Pinned sites*
  • Monthly Budget*
  • Excluded sites

*pinned sites and monthly budget import are tied together. See #1910, specifically @jenn-rhim 's comment , for details.

@davidtemkin davidtemkin added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Nov 8, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 13, 2018
@bsclifton bsclifton modified the milestones: 1.x Backlog, 0.57.x - Beta Nov 28, 2018
@bsclifton
Copy link
Member

bsclifton commented Nov 28, 2018

Fixed with brave/brave-core#736

Not verifiable via the UI unfortunately because of #2265

@btlechowski
Copy link

btlechowski commented Dec 6, 2018

Verification Passed on

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

Used STR from brave/brave-core#736
Also imported using --upgrade-from-muon flag

Verified import is canceled when Brave Payments in b-l are turned off
Verified that following settings were imported:

  • Minimum page time before logging a visit
  • Minimum visits for publisher relevancy
  • Allow contributions to non-verified sites
  • Allow contributions to videos
  • Wallet (this includes Grants; attached to wallet by way of server query) Checked addresses in UI and ledger_state
  • Monthly Budget
  • Pinned sites (Tips)
  • Turning auto-contribute on/off based on ledger table and pinned sites

Verified passed on

Brave 0.57.18 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification passed on

Brave 0.57.18 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests