Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show new transactions in BuySendSwap transactions list #20677

Closed
Pavneet-Sing opened this issue Jan 25, 2022 · 1 comment · Fixed by brave/brave-core#12101
Closed

Show new transactions in BuySendSwap transactions list #20677

Pavneet-Sing opened this issue Jan 25, 2022 · 1 comment · Fixed by brave/brave-core#12101
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jan 25, 2022

Description

New transactions are not being added in transactions list

Steps to reproduce

  1. Login wallet, Select ETH (or any) coin in the list
  2. Perform a swap (or any transaction)
  3. Verify if the new transaction is being shown on buysendswap screen

Actual result

New transactions are not being shown in the transaction list

buysendswap.update.transaction.mp4

Expected result

List should show the new transactions (should show the unapproved transaction).

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): All
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.36.67

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@Pavneet-Sing Pavneet-Sing added the OS/Android Fixes related to Android browser functionality label Jan 25, 2022
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 26, 2022
@anthonypkeane anthonypkeane added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 26, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 31, 2022
@Pavneet-Sing Pavneet-Sing added this to the 1.37.x - Nightly milestone Feb 2, 2022
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.37.89 x64 beta build

  • Verified steps from issue description
  • Verified new transactions are listed in asset details view
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
20677-ARM.mp4
20677-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants