Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resize limitation for PictureInPicture window #20789

Closed
spylogsster opened this issue Jan 30, 2022 · 2 comments · Fixed by brave/brave-core#12066
Closed

Remove resize limitation for PictureInPicture window #20789

spylogsster opened this issue Jan 30, 2022 · 2 comments · Fixed by brave/brave-core#12066

Comments

@spylogsster
Copy link

Description

I often use Picture in picture and it has limitation for the size of the window, it is very convenient when possible to expand it for full size.

Steps to Reproduce

  1. open picture in picture
  2. move window to second monitor
  3. resize it for full size

Actual result:

Resize is limited by half size

Expected result:

Able to set full size

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 8, 2022

Brave 1.37.84 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 11 Version 21H2 (Build 22000.493)
  • Install 1.37.x
  • Launch brave
  • Navigated to Youtube and started playing a video (eg. NCS music videos)
  • Clicked on PIP icon in the top right next to address bar
  • Clicked on Enter Picture-in-Picture icon (next to skip video icon)
  • Video should be playing in a Floating window
  • Verified the PIP window can be resized to full screen
  • Dragged it to second monitor and resized to full screen
  • Clicked Back to tab icon or x in PIP to exit
2022-03-08_15h36_48.mp4

Verification passed on

Brave 1.37.86 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#12066

image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 9, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.37.93 Chromium: 99.0.4844.51 (Official Build) dev (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 11.6.3 (Build 20G415)
example example
Screen Shot 2022-03-15 at 3 26 08 PM Screen Shot 2022-03-15 at 3 26 35 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment