Only one regional adblock filter list is selected in brave://adblock

[btlechowski]

Some locales have more than one list, but only one list is selected on clean install

Steps to Reproduce

1. Clean profile
2. Start Brave in Polish (PL) locale
3. Open brave://adblock

Actual result:

One one list is selected for PL locale even though there are 3

Expected result:

All 3 lists are selected

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	1.35.99 Chromium: 98.0.4758.87 (Official Build) (64-bit)
Revision	e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @antonok-edm

[rebron]

cc: @ryanbr

[antonok-edm]

All 3 of these lists have "langs": ["pl"] in the descriptor, so I suspect the issue is with the in-browser preselection logic.

[btlechowski]

Added OS/Android as brave://adblock is available on Android. Also added QA/Test-All-Platforms as each platform may set language differently.

[stephendonner]

Verified PASSED using

Brave	1.50.86 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	macOS Version 11.7.4 (Build 20G1120)

Confirmed the 3 Polish filter-list options were pre-selected when I set macOS to Polish for my language/region

example	example

[btlechowski]

Verification passed on

Brave	1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Ubuntu 18.04 LTS

Verified test plan from the description and brave/brave-core#17261

Clean profile

Verified all 3 filter lists are selected

Migration - unchanged

1.49.x - only one filter list is selected

Verified all 3 filter lists are selected after upgrade

Migration - changed

1.49.x - only one filter list is selected

Verified nothing changed after upgrade

[MadhaviSeelam]

Verification PASSED using

Brave | 1.50.107 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
-- | --
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Pre-requisites:

• Configure Brave to use Polish locale using the language code pl , es, ru by following below steps:
  • Browse Brave's regional list catalog here and find a language short-code used by more than one list (e.g. pl, is, es).
  • Configure Brave to use a locale with the selected language short-code according to instructions here

Case 1: Clean profile - pl - Polish locale and ko - Korean - PASSED

1. install 1.50.107
2. completed pre-requisite steps from above for each locale
3. launched Brave
4. visited brave://settings/shields/filters
5. expanded the Filter list

Confirmed the 3 Polish filter-list options were pre-selected in the Filter lists for selected language short-code which is pl

pl - Korea

step 4	result

ko - Korean

Confirmed a single filter-list option was pre-selected in the Filter lists for the selected locale Korea

step 4	result

Case 2: Migration - unchanged - pl - Polish - PASSED

1. installed 1.49.132
2. completed pre-requisite steps from above for pl locale
3. launched Brave
4. visited brave://settings/shields/filters in a new-tab
5. expand the Filter list
6. confirmed single option was selected
7. close the browser
8. relaunch the profile with Brave Browser-Beta

Confirmed the 3 Polish filter-list options were pre-selected in the Filter lists for the selected locale Polish when upgraded from 1.49.x to 1.50.x

1.49.x	1.50.x

Case 3: Migration - with additional language codes ("langs": ["es", "pt"]) - PASSED

1. Installed 1.49.132
2. completed pre-requisite steps from above for es locale
3. launched Brave
4. visited brave://settings/shields/filters in a new-tab
5. expanded the Filter list
6. EasyList Spanish is enabled
7. closed the browser
8. relaunched the profile with Brave Browser-Beta

Confirmed In addition to EasyList Spanish, Adguard Spanish/Portuguese

Confirmed Fanboy's Mobile Notifications List is selected upon upgrade which is expected.

step 7	result

Case 4: Migration - modified entries - ru - Russian

1. installed 1.49.132
2. completed pre-requisite steps from above for ru locale
3. launched Brave
4. visited brave://settings/shields/filters in a new-tab
5. expanded the Filter list
6. Ru AdList selection is enabled as per the selected language code, ru as expected
7. disabled Ru Adlist selection
8. enabled Adguard Russian Filter selection
9. closed the browser
10. relaunched the profile with Brave Browser-Beta

Confirmed Adguard Russian selection remains selected.

step 7	step 9	step 10

[GeetaSarvadnya]

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarmx64.apk_1.50.113

Verified test plan from the description and brave/brave-core#17261

Clean profile

Verified all 3 filter lists are selected

Upgrade profile

1.49.x - only one filter list is selected

Verified all 3 filter lists are selected after upgrade to 1.50.113