Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync] Disable expiring of devices #20937

Closed
AlexeyBarabash opened this issue Feb 7, 2022 · 4 comments · Fixed by brave/brave-core#12005
Closed

[Sync] Disable expiring of devices #20937

AlexeyBarabash opened this issue Feb 7, 2022 · 4 comments · Fixed by brave/brave-core#12005

Comments

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Feb 7, 2022

It is required to disable Chromium's feature of expiring old (>56 days) devices in the sync chain. For the existing browser profiles the devices should be re-fetched from the server.

We need this because now the number of devices is limited to 50 per the sync chain and some users have an error of max num devices in chain, but in their list there are less than 50.

@stephendonner
Copy link

While not actively blocked, setting QA-Blocked while I work on refining the testplan 👍

@stephendonner
Copy link

stephendonner commented Mar 13, 2022

Verified PASSED using

Brave 1.37.89 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 10 Version 21H2 (Build 19044.1586)

Steps:

  1. launched desktop using --sync-url=https://sync-v2.brave.software/v2
  2. joined the provided test Sync chain using code words
  3. confirmed I saw the HAPPYUBU7 devices
  4. launched Android using --sync-url=https://sync-v2.brave.software/v2
  5. joined the Sync chain by scanning the QR code on desktop, from Android

confirmed I saw the HAPPYUBU7 devices

confirmed my Android, Windows, and [iOS-pending] devices could all see each other in the chain

Win10 macOS Android iOS?
Screen Shot 2022-03-12 at 10 39 27 AM Screen Shot 2022-03-12 at 10 39 27 AM Screenshot_20220312-102430 [iOS?]
NOTE: Will return to verify with iOS, when a 1.37.x build is available.

Verified PASSED using

Brave 1.37.91 Chromium: 99.0.4844.51 (Official Build) beta (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 12.3 (Build 21E230)

Steps:

  1. launched desktop using --sync-url=https://sync-v2.brave.software/v2
  2. joined the provided test Sync chain using code words
  3. confirmed I saw the HAPPYUBU7 devices
  4. launched Android using --sync-url=https://sync-v2.brave.software/v2
  5. joined the Sync chain by scanning the QR code on desktop, from Android

confirmed I saw the HAPPYUBU7 devices

confirmed my Android, Windows, and [iOS-pending] devices could all see each other in the chain

Win10 macOS Android iOS?
image Screen Shot 2022-03-14 at 11 41 18 PM Screenshot_20220314-234210 [iOS?]
NOTE: Will return to verify with iOS, when available.

Verification passed on

Brave 1.37.95 Chromium: 99.0.4844.74 (Oficjalna wersja) beta (64-bitowa)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Ubuntu 18.04 LTS

image
Screenshot_20220322-000209_Brave - Beta

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 16, 2022

Verification PASSED on Android ARM using version Beta 1.37.94, Chromium 99.0.4844.74

Device: Samsung Galaxy S21 running Android 12

  • Verified able to connect to the staging sync chain using STR from slack thread:
  • Verified older devices are still show up on sync chain
  • Scanned QR Code from desktop sync chain
  1. Disconnect network
  2. Install Browser via APK
  3. Enable dev tools and add the command line string --sync-url=https://sync-v2.brave.software/v2
  4. Quit browser after relaunch
  5. Connect back to network and relaunch browser, should start using staging URL for Sync
  6. Navigate to settings > sync and scan sync QR code

Screen Shot 2022-03-16 at 1 40 52 PM

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 16, 2022

Verification PASSED on Android Tab using version Beta 1.37.94, Chromium 99.0.4844.74

Device: Samsung Galaxy Tab S7 running Android 11

  • Verified able to connect to the staging sync chain using STR from slack thread:
  • Verified older devices are still show up on sync chain
  • Scanned QR Code from desktop sync chain
  1. Disconnect network
  2. Install Browser via APK
  3. Enable dev tools and add the command line string --sync-url=https://sync-v2.brave.software/v2
  4. Quit browser after relaunch
  5. Connect back to network and relaunch browser, should start using staging URL for Sync
  6. Navigate to settings > sync and scan sync QR code

Screen Shot 2022-03-16 at 2 31 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment