-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sync] Disable expiring of devices #20937
Labels
feature/sync
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Device-Types
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
AlexeyBarabash
added
QA/Yes
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Feb 7, 2022
25 tasks
While not actively blocked, setting |
Verified
|
Brave | 1.37.89 Chromium: 99.0.4844.51 (Official Build) beta (64-bit) |
---|---|
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875} |
OS | Windows 10 Version 21H2 (Build 19044.1586) |
Steps:
- launched desktop using
--sync-url=https://sync-v2.brave.software/v2
- joined the provided test Sync chain using code words
- confirmed I saw the
HAPPYUBU7
devices - launched Android using
--sync-url=https://sync-v2.brave.software/v2
- joined the Sync chain by scanning the QR code on desktop, from Android
confirmed I saw the HAPPYUBU7
devices
confirmed my Android, Windows, and [iOS-pending] devices could all see each other in the chain
Win10 |
macOS |
Android |
iOS? |
---|---|---|---|
[iOS?] |
NOTE: Will return to verify with iOS, when a 1.37.x
build is available.
Verified PASSED
using
Brave | 1.37.91 Chromium: 99.0.4844.51 (Official Build) beta (x86_64) |
---|---|
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875} |
OS | macOS Version 12.3 (Build 21E230) |
Steps:
- launched desktop using
--sync-url=https://sync-v2.brave.software/v2
- joined the provided test Sync chain using code words
- confirmed I saw the
HAPPYUBU7
devices - launched Android using
--sync-url=https://sync-v2.brave.software/v2
- joined the Sync chain by scanning the QR code on desktop, from Android
confirmed I saw the HAPPYUBU7
devices
confirmed my Android, Windows, and [iOS-pending] devices could all see each other in the chain
Win10 |
macOS |
Android |
iOS? |
---|---|---|---|
[iOS?] |
NOTE: Will return to verify with iOS, when available.
Verification passed on
Brave | 1.37.95 Chromium: 99.0.4844.74 (Oficjalna wersja) beta (64-bitowa) |
---|---|
Revision | fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060} |
OS | Ubuntu 18.04 LTS |
Verification PASSED on Device:
|
Verification PASSED on Device:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/sync
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Device-Types
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
It is required to disable Chromium's feature of expiring old (>56 days) devices in the sync chain. For the existing browser profiles the devices should be re-fetched from the server.
We need this because now the number of devices is limited to 50 per the sync chain and some users have an error of max num devices in chain, but in their list there are less than 50.
The text was updated successfully, but these errors were encountered: