Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better selection of RPC URLs after input from chainlist.org with variables and wss:// (Affects Arbitrum) #20958

Closed
bbondy opened this issue Feb 7, 2022 · 0 comments · Fixed by brave/brave-core#12180
Closed

Better selection of RPC URLs after input from chainlist.org with variables and wss:// (Affects Arbitrum) #20958

bbondy opened this issue Feb 7, 2022 · 0 comments · Fixed by brave/brave-core#12180
Assignees
@bbondy
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No QA/Test-Plan-Specified release-notes/include
Milestone
1.37.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Feb 7, 2022 •
edited
Loading

After adding Arbitrum from chainlist.org I noticed that the first networks were

https://arbitrum-mainnet.infura.io/v3/${INFURA_API_KEY}
https://arb-mainnet.g.alchemy.com/v2/${ALCHEMY_API_KEY}

It does list some other networks though.

This causes some people in community support to not work correctly.
https://community.brave.com/t/brave-wallet-not-allowing-0-gas-price-on-arbitrum-test-network/308777/13
https://community.brave.com/t/unable-to-send-eth-arbitrum-chain/317080/9

This one works:
https://arb1.arbitrum.io/rpc

Note it also adds one like this:
wss://arb1.arbitrum.io/ws

We should select the first reasonable URL instead (i.e. one without variables and one that is HTTP(S)) when possible.
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 7, 2022
@kjozwiak kjozwiak added the feature/web3/wallet Integrating Ethereum+ wallet support label Feb 8, 2022
@bbondy bbondy changed the title Chainlist.org can list some networks wrongly Better selection of RPC URLs after input from chainlist.org with variables and wss:// Feb 8, 2022
@bbondy bbondy mentioned this issue Feb 8, 2022
Merged
25 tasks
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 8, 2022
@bbondy bbondy self-assigned this Feb 8, 2022
@bbondy bbondy added this to the 1.37.x - Nightly milestone Feb 9, 2022
@bbondy bbondy changed the title Better selection of RPC URLs after input from chainlist.org with variables and wss:// Better selection of RPC URLs after input from chainlist.org with variables and wss:// (Affects Arbitrum) Feb 9, 2022
@bbondy bbondy added QA/No and removed QA/Yes labels Mar 23, 2022
This was referenced Mar 30, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No QA/Test-Plan-Specified release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Select first reasonable URL for RPC urls brave/brave-core
2 participants
@bbondy @kjozwiak