Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap Container Dynamic Sizing Bug #21061

Closed
Douglashdaniel opened this issue Feb 11, 2022 · 1 comment · Fixed by brave/brave-core#12287
Closed

Swap Container Dynamic Sizing Bug #21061

Douglashdaniel opened this issue Feb 11, 2022 · 1 comment · Fixed by brave/brave-core#12287
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@Douglashdaniel
Copy link

Description

Currently there is a styling bug with the Swap container that is not allowing it to dynamically grow when errors are shown.

Screen Shot 2022-02-11 at 12 15 05 PM
@Douglashdaniel Douglashdaniel added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 11, 2022
@Douglashdaniel Douglashdaniel self-assigned this Feb 11, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Feb 16, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 16, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Feb 16, 2022
Closed
@Uni-verse
Copy link
Contributor

Verification completed using

Brave	1.37.105 Chromium: 100.0.4896.46 (Official Build) (x86_64) 
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS	macOS Version 12.1 (Build 21C52)
  • Expanding/collapsing slippage field does not overflow text
  • Generating slippage error does not change ui/overflow
set slippage expand/collapse
Screen Shot 2022-03-29 at 2 21 00 PM Screen Shot 2022-03-29 at 2 21 18 PM

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Swap Container Dynamic Sizing Bug brave/brave-core
2 participants
@Uni-verse @Douglashdaniel